Skip to content

Conversation

@suisin-deriv
Copy link
Contributor

Changes:

Fixed user have to scroll to see the next button issue for pop-up modal.

Screenshot 2023-12-13 at 12 03 56 PM

Screenshots:

Previous issue:

Screenshot 2023-12-13 at 12 04 28 PM

@vercel
Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 14, 2023 4:34am

@coveralls
Copy link

coveralls commented Dec 13, 2023

Coverage Status

coverage: 31.618% (+0.2%) from 31.371%
when pulling e939f5b on suisin-deriv:suisin/COJ265/next_button_cropped_issue
into 9c7a251 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12216](https://github.com/binary-com/deriv-app/pull/12216)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-coj265nextbuttonc-dfc734.binary.sx?qa_server=red.derivws.com&app_id=32134
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-coj265nextbuttonc-dfc734.binary.sx
- **App ID**: `32134`

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-coj265nextbuttonc-dfc734.binary.sx/

likhith-deriv
likhith-deriv previously approved these changes Dec 13, 2023
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
13.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@hamza-deriv hamza-deriv merged commit 423bd40 into deriv-com:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants