-
Notifications
You must be signed in to change notification settings - Fork 379
[WALL] Rostislav / WALL-3069 / Use requests instead of subscriptions for exchange rates in transfer messages and transfer inputs #12229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-transfer-me-b0527e.binary.sx/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the reason for that switch? optimise / backend complaints about too many subscriptions etc?
We only require the value to be updated every 60s as per requirement. If we subscribe to exchange_rate, we cannot guarantee that. |
Yup, this PR makes the exchange rates updates to input values and transfer messages synced and initiated by the timer. |
...ures/cashier/modules/Transfer/components/TransferFormAmountInput/TransferFormAmountInput.tsx
Show resolved
Hide resolved
...ures/cashier/modules/Transfer/components/TransferFormAmountInput/TransferFormAmountInput.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth adding tests? sooner rather than later tests for all new stuff are gonna be expected to be covered in unit or component tests
e4fe0bf
…r-messages-requests-for-exchange-rates
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
❌ Smoke test run (1) failed. See logs for details: Visit Action |
❌ Smoke test run (2) failed. See logs for details: Visit Action |
Tests for |
Changes:
useGetExchangeRate
Screenshots:
Screen.Recording.2023-12-13.at.13.44.51.mov