Skip to content

Conversation

rostislav-deriv
Copy link
Contributor

Changes:

  • add useGetExchangeRate
  • switch to using timer-initiated exchange rates requests instead of subscriptions in transfer

Screenshots:

Screen.Recording.2023-12-13.at.13.44.51.mov

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 15, 2023 3:51pm

Copy link
Contributor

github-actions bot commented Dec 13, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12229](https://github.com/binary-com/deriv-app/pull/12229)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rostislav-deriv-rostislav-transfer-me-b0527e.binary.sx?qa_server=red.derivws.com&app_id=31385
    - **Original**: https://deriv-app-git-fork-rostislav-deriv-rostislav-transfer-me-b0527e.binary.sx
- **App ID**: `31385`

Copy link
Contributor

github-actions bot commented Dec 13, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-transfer-me-b0527e.binary.sx/

@coveralls
Copy link

coveralls commented Dec 13, 2023

Coverage Status

coverage: 32.613% (+0.01%) from 32.602%
when pulling 8b0151d on rostislav-deriv:rostislav/transfer-messages-requests-for-exchange-rates
into c7ab037 on binary-com:master.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the reason for that switch? optimise / backend complaints about too many subscriptions etc?

@nijil-deriv
Copy link
Contributor

whats the reason for that switch? optimise / backend complaints about too many subscriptions etc?

We only require the value to be updated every 60s as per requirement. If we subscribe to exchange_rate, we cannot guarantee that.

@rostislav-deriv
Copy link
Contributor Author

Yup, this PR makes the exchange rates updates to input values and transfer messages synced and initiated by the timer.

heorhi-deriv
heorhi-deriv previously approved these changes Dec 14, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding tests? sooner rather than later tests for all new stuff are gonna be expected to be covered in unit or component tests

ghost
ghost previously approved these changes Dec 15, 2023
heorhi-deriv
heorhi-deriv previously approved these changes Dec 15, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@rostislav-deriv
Copy link
Contributor Author

Tests for useTransferMessages will be added in a separate soon-to-be-created-by-me PR
cc @wojciech-deriv

@nijil-deriv nijil-deriv merged commit 164b965 into deriv-com:master Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants