chore: add clickjacking preventation headers for cloudflare #12241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markw-deriv
requested review from
ali-hosseini-deriv,
maryia-deriv and
matin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Contributor
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
Contributor
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-markwylde-deriv-add-clickjacking-prev-1cf746.binary.sx/ |
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Contributor
|
This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was taken from this PR:
https://github.com/binary-com/deriv-app/pull/11805/files#diff-50cb9f3ec9ba414669cac19486feb1dd8ede43c2d01a245dbce14a6f4d7e321a
I'm not convinced this will actually add the headers to cloudflare. So this PR will test to make sure it's there, and if it works, we can merge the other PR to remove the clickjacking js code snippet.