Skip to content

Conversation

@henry-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Screenshot 2023-12-18 at 12 22 48 PM Screenshot 2023-12-19 at 2 49 09 PM

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app 🛑 Canceled (Inspect) Dec 19, 2023 7:16am

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12355](https://github.com/binary-com/deriv-app/pull/12355)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-henry-deriv-henry-webrel-54test-cover-287df9.binary.sx?qa_server=red.derivws.com&app_id=31585
    - **Original**: https://deriv-app-git-fork-henry-deriv-henry-webrel-54test-cover-287df9.binary.sx
- **App ID**: `31585`

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 17
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-webrel-54test-cover-287df9.binary.sx/

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Dec 19, 2023

Coverage Status

coverage: 33.265% (+0.05%) from 33.215%
when pulling 7ab1c6b on henry-deriv:henry/webrel-54/test-coverage-trader-header-extension-populate-header
into 5ebde58 on binary-com:master.

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@balakrishna-deriv balakrishna-deriv merged commit 01f580e into deriv-com:master Dec 20, 2023
lubega-deriv pushed a commit to lubega-deriv/deriv-app that referenced this pull request Dec 26, 2023
…the header (deriv-com#12355)

* fix: test coverage for portfolio component

* fix: remove unused code

Signed-off-by: lubega-deriv <lubega@deriv.com>
lubega-deriv pushed a commit to lubega-deriv/deriv-app that referenced this pull request Dec 26, 2023
…the header (deriv-com#12355)

* fix: test coverage for portfolio component

* fix: remove unused code

Signed-off-by: lubega-deriv <lubega@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants