Skip to content

Conversation

hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

EnterPassword modal
Implement EnterPassword modal when the password is already created for another account.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 20, 2023 7:51am

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12402](https://github.com/binary-com/deriv-app/pull/12402)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-trah-2301enter-password.binary.sx?qa_server=red.derivws.com&app_id=32820
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-trah-2301enter-password.binary.sx
- **App ID**: `32820`

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@coveralls
Copy link

Coverage Status

coverage: 33.549%. remained the same
when pulling 5e33736 on hamza-deriv:hamza/TRAH-2301/Enter-Password
into 4fc0402 on binary-com:master.

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-trah-2301enter-password.binary.sx/

@hamza-deriv hamza-deriv merged commit db8408f into deriv-com:master Dec 20, 2023
lubega-deriv pushed a commit to lubega-deriv/deriv-app that referenced this pull request Dec 26, 2023
Signed-off-by: lubega-deriv <lubega@deriv.com>
lubega-deriv pushed a commit to lubega-deriv/deriv-app that referenced this pull request Dec 26, 2023
Signed-off-by: lubega-deriv <lubega@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants