[DTRA] Maryia/WEBREL-29/test: Stores/Modules/Trading/Actions files in Trader package #12459

maryia-deriv · 2023-12-21T15:11:01Z

Changes:

To add test coverage for files in Stores/Modules/Trading/Actions directory of Trader package:

To write unit test for src/Stores/Modules/Trading/Actions/contract-type.ts file
To write unit test for src/Stores/Modules/Trading/Actions/duration.ts file
+ fix a bug in duration.ts
To write unit test for src/Stores/Modules/Trading/Actions/purchase.ts file
To write unit test for src/Stores/Modules/Trading/Actions/start-date.ts file
To write unit test for src/Stores/Modules/Trading/Actions/symbol.ts file

Screenshots:

vercel · 2023-12-21T15:11:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Jan 25, 2024 2:24pm

github-actions · 2023-12-21T15:28:43Z

A production App ID was automatically generated for this PR. (log)

PR: [DTRA] Maryia/WEBREL-29/test: Stores/Modules/Trading/Actions files in Trader package #12459
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-maryia-deriv-maryia-webrel-29test-act-8fb774.binary.sx?qa_server=red.derivws.com&app_id=24182
- Original: https://deriv-app-git-fork-maryia-deriv-maryia-webrel-29test-act-8fb774.binary.sx
App ID: 24182

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/12459](https://github.com/binary-com/deriv-app/pull/12459)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-deriv-maryia-webrel-29test-act-8fb774.binary.sx?qa_server=red.derivws.com&app_id=24182
    - **Original**: https://deriv-app-git-fork-maryia-deriv-maryia-webrel-29test-act-8fb774.binary.sx
- **App ID**: `24182`

coveralls · 2023-12-21T15:29:38Z

coverage: 34.905% (+0.03%) from 34.88%
when pulling 3b5a51d on maryia-deriv:maryia/WEBREL-29/test-actions-files
into 5a0214d on binary-com:master.

github-actions · 2023-12-21T15:29:48Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	88
🟢 Best practices	92
🟢 SEO	92
🟧 PWA	80

Lighthouse ran with https://deriv-app-git-fork-maryia-deriv-maryia-webrel-29test-act-8fb774.binary.sx/

…ntract-type.spec.ts

github-actions · 2023-12-26T00:16:45Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-26T00:16:46Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-26T00:17:17Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-26T00:17:24Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-26T00:18:54Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-26T00:18:54Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-26T00:19:26Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

kate-deriv · 2023-12-26T07:13:04Z

packages/trader/src/Stores/Modules/Trading/Actions/__tests__/duration.spec.ts

+                                    barrier: barrier_intraday,
+                                    barrier_choices: barrier_choices_intraday,
+                                    contract_display: 'Vanilla Long Put',
+                                    contract_type: 'VANILLALONGPUT',


I guess, if you are using TRADE_TYPES.VANILLA.CALL below, it can be also applied here and on lines 90,79, 68, 54
Please, ignore if not relevant

@kate-deriv unfortunately, using external variables is prohibited inside jest.mocks

Oh, sorry I didn't know

kate-deriv · 2023-12-26T07:15:42Z

packages/trader/src/Stores/Modules/Trading/Actions/__tests__/start-date.spec.ts

+                                    barrier: barrier_intraday,
+                                    barrier_choices: barrier_choices_intraday,
+                                    contract_display: 'Vanilla Long Put',
+                                    contract_type: 'VANILLALONGPUT',


Probably, same in this file

same as #12459 (comment)

…iles

sonarqubecloud · 2024-01-25T14:10:42Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
4.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-01-25T14:25:49Z

⏳ Generating Lighthouse report...

boring-cyborg bot added the Trader label Dec 21, 2023

maryia-deriv temporarily deployed to Preview December 21, 2023 15:12 — with GitHub Actions Inactive

maryia-deriv temporarily deployed to Preview December 21, 2023 15:30 — with GitHub Actions Inactive

maryia-deriv temporarily deployed to Preview December 22, 2023 09:22 — with GitHub Actions Inactive

maryia-deriv temporarily deployed to Preview December 22, 2023 10:08 — with GitHub Actions Inactive

maryia-deriv force-pushed the maryia/WEBREL-29/test-actions-files branch from f0e5ee1 to e714d72 Compare December 22, 2023 10:21

maryia-deriv temporarily deployed to Preview December 22, 2023 10:21 — with GitHub Actions Inactive

maryia-deriv temporarily deployed to Preview December 22, 2023 10:23 — with GitHub Actions Inactive

maryia-deriv temporarily deployed to Preview December 22, 2023 10:31 — with GitHub Actions Inactive

maryia-deriv added 4 commits December 22, 2023 15:46

test: init contract-type.spec

18b2ca1

test: packages/trader/src/Stores/Modules/Trading/Actions/__tests__/co…

f1354ea

…ntract-type.spec.ts

refactor: test for contract-type

9999fe5

test: duration

df0f610

maryia-deriv force-pushed the maryia/WEBREL-29/test-actions-files branch from 99bcff8 to df0f610 Compare December 22, 2023 12:47

maryia-deriv temporarily deployed to Preview December 22, 2023 12:48 — with GitHub Actions Inactive

test: duration

c42280c

maryia-deriv temporarily deployed to Preview December 22, 2023 14:42 — with GitHub Actions Inactive

maryia-deriv temporarily deployed to Preview December 25, 2023 23:59 — with GitHub Actions Inactive

maryia-deriv marked this pull request as ready for review December 26, 2023 00:02

maryia-deriv requested a review from matin-deriv as a code owner December 26, 2023 00:02

kate-deriv reviewed Dec 26, 2023

View reviewed changes

balakrishna-deriv approved these changes Dec 26, 2023

View reviewed changes

kate-deriv approved these changes Dec 26, 2023

View reviewed changes

akmal-deriv approved these changes Dec 26, 2023

View reviewed changes

henry-deriv approved these changes Dec 26, 2023

View reviewed changes

Merge branch 'binary-com:master' into maryia/WEBREL-29/test-actions-f…

a393ecc

…iles

maryia-deriv temporarily deployed to Preview January 18, 2024 09:17 — with GitHub Actions Inactive

maryia-deriv temporarily deployed to Preview January 18, 2024 09:18 — with GitHub Actions Inactive

Merge branch 'binary-com:master' into maryia/WEBREL-29/test-actions-f…

3b5a51d

…iles

maryia-deriv temporarily deployed to Preview January 25, 2024 14:05 — with GitHub Actions Inactive

balakrishna-deriv merged commit d8f584d into deriv-com:master Feb 5, 2024

[DTRA] Maryia/WEBREL-29/test: Stores/Modules/Trading/Actions files in Trader package #12459

[DTRA] Maryia/WEBREL-29/test: Stores/Modules/Trading/Actions files in Trader package #12459

Uh oh!

Conversation

maryia-deriv commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Screenshots:

Uh oh!

vercel bot commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 26, 2023

Uh oh!

github-actions bot commented Dec 26, 2023

Uh oh!

github-actions bot commented Dec 26, 2023

Uh oh!

github-actions bot commented Dec 26, 2023

Uh oh!

github-actions bot commented Dec 26, 2023

Uh oh!

github-actions bot commented Dec 26, 2023

Uh oh!

github-actions bot commented Dec 26, 2023

Uh oh!

kate-deriv Dec 26, 2023

Choose a reason for hiding this comment

Uh oh!

maryia-deriv Dec 26, 2023

Choose a reason for hiding this comment

Uh oh!

kate-deriv Dec 26, 2023

Choose a reason for hiding this comment

Uh oh!

kate-deriv Dec 26, 2023

Choose a reason for hiding this comment

Uh oh!

maryia-deriv Dec 26, 2023

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 25, 2024

Quality Gate passed

Uh oh!

github-actions bot commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

maryia-deriv commented Dec 21, 2023 •

edited

Loading

vercel bot commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Dec 21, 2023 •

edited

Loading

coveralls commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Dec 21, 2023 •

edited

Loading