Skip to content

Conversation

rostislav-deriv
Copy link
Contributor

Changes:

  • minor refactoring

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 10:19am

Copy link
Contributor

github-actions bot commented Jan 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12714](https://github.com/binary-com/deriv-app/pull/12714)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rostislav-deriv-rostislav-tradershub-ci-fix.binary.sx?qa_server=red.derivws.com&app_id=24068
    - **Original**: https://deriv-app-git-fork-rostislav-deriv-rostislav-tradershub-ci-fix.binary.sx
- **App ID**: `24068`

Copy link
Contributor

github-actions bot commented Jan 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-tradershub-ci-fix.binary.sx/

@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

Changes unknown
when pulling 70b351b on rostislav-deriv:rostislav/tradershub-ci-fix
into ** on binary-com:master**.

matin-deriv
matin-deriv previously approved these changes Jan 4, 2024
ghost
ghost previously approved these changes Jan 4, 2024
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@rostislav-deriv
Copy link
Contributor Author

The CI has been fixed in #12735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants