Skip to content

[TRAH] hotfix: add missing prop in clipboard which causing error #12723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2024
Merged

[TRAH] hotfix: add missing prop in clipboard which causing error #12723

merged 2 commits into from
Jan 4, 2024

Conversation

shontzu-deriv
Copy link
Contributor

Changes:

  • this thing has merged yesterday and it causing some issues on some of the prs

Screenshots:

image

@vercel Vercel
Copy link

vercel bot commented Jan 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 5:14am

hamza-deriv
hamza-deriv previously approved these changes Jan 4, 2024
View reviewed changes
@shontzu-deriv shontzu-deriv force-pushed the shontzu/clipboard-hotfix branch from cde2859 to 01fad3a Compare January 4, 2024 04:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12723](https://github.com/binary-com/deriv-app/pull/12723)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-clipboard-hotfix.binary.sx?qa_server=red.derivws.com&app_id=30346
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-clipboard-hotfix.binary.sx
- **App ID**: `30346`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-clipboard-hotfix.binary.sx/

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.9% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Jan 4, 2024 •
edited
Loading

Coverage Status

coverage: 34.249% (+0.001%) from 34.248%
when pulling 1014d74 on shontzu-deriv:shontzu/clipboard-hotfix
into 884c759 on binary-com:master.

@hirad-deriv hirad-deriv merged commit 9e1c725 into deriv-com:master Jan 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@shontzu-deriv shontzu-deriv mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirad-deriv hirad-deriv hirad-deriv approved these changes

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@hamza-deriv hamza-deriv Awaiting requested review from hamza-deriv

+1 more reviewer

@ali-hosseini-deriv ali-hosseini-deriv ali-hosseini-deriv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shontzu-deriv @coveralls @ali-hosseini-deriv @hirad-deriv @hamza-deriv