Skip to content

[TRAH] Arshad /TRAH-2618/ Dynamic leverage title component #12748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 5, 2024
Merged

[TRAH] Arshad /TRAH-2618/ Dynamic leverage title component #12748

merged 5 commits into from
Jan 5, 2024

Conversation

@arshad-rao-deriv
Copy link
Contributor

Changes:

Added Dynamic Leverage Title Component to Trader's Hub
CU: https://app.clickup.com/t/20696747/TRAH-2618

Screenshots:

image

@vercel
Copy link

vercel bot commented Jan 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 5, 2024 7:24am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12748](https://github.com/binary-com/deriv-app/pull/12748)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-arshad-rao-deriv-arshad-trah-2618dyna-4aebe5.binary.sx?qa_server=red.derivws.com&app_id=24068
    - **Original**: https://deriv-app-git-fork-arshad-rao-deriv-arshad-trah-2618dyna-4aebe5.binary.sx
- **App ID**: `24068`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-arshad-rao-deriv-arshad-trah-2618dyna-4aebe5.binary.sx/

@coveralls
Copy link

coveralls commented Jan 4, 2024 •
edited
Loading

Coverage Status

coverage: 34.66% (+0.2%) from 34.467%
when pulling ba3a130 on arshad-rao-deriv:Arshad/TRAH-2618/DynamicLeverageTitleComponent
into d2cd2f3 on binary-com:master.

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Jan 5, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@hirad-deriv hirad-deriv merged commit 60ed913 into deriv-com:master Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirad-deriv hirad-deriv hirad-deriv approved these changes

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

+3 more reviewers

@aizad-deriv aizad-deriv aizad-deriv left review comments

@hamza-deriv hamza-deriv hamza-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@arshad-rao-deriv arshad-rao-deriv

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arshad-rao-deriv @coveralls @hirad-deriv @aizad-deriv @thisyahlen-deriv @hamza-deriv