Skip to content

Conversation

@henry-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 9, 2024 8:45am

@henry-deriv henry-deriv changed the title [DTRA] henry/dtra-675/fix: remove tick history subscribe when market is closed [DTRA] henry/dtra-675/fix: remove tick history subscribe and show chart when market is closed Jan 5, 2024
@coveralls
Copy link

coveralls commented Jan 5, 2024

Coverage Status

Changes unknown
when pulling 6bf1f9b on henry-deriv:henry/dtra-675/show-historical-chart-when-market-is=closed
into ** on binary-com:master**.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12764](https://github.com/binary-com/deriv-app/pull/12764)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-henry-deriv-henry-dtra-675show-histor-5ad544.binary.sx?qa_server=red.derivws.com&app_id=24195
    - **Original**: https://deriv-app-git-fork-henry-deriv-henry-dtra-675show-histor-5ad544.binary.sx
- **App ID**: `24195`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-dtra-675show-histor-5ad544.binary.sx/

…tra-675/show-historical-chart-when-market-is=closed
…tra-675/show-historical-chart-when-market-is=closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@balakrishna-deriv balakrishna-deriv merged commit 61c1a13 into deriv-com:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants