Skip to content

Conversation

maryia-matskevich-deriv
Copy link
Contributor

Changes:

fix: Responsive/ On Quick strategy modal, the dropdown in overlapping with the text

Screenshots:

Please provide some screenshots of the change.
Screenshot 2024-01-05 at 11 05 54

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 5, 2024 8:46am

Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
11.4% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 34.655%. remained the same
when pulling 8ebdd02 on maryia-matskevich-deriv:maryia/webrel-1870
into 9188660 on binary-com:master.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12772](https://github.com/binary-com/deriv-app/pull/12772)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-webrel-1870.binary.sx?qa_server=red.derivws.com&app_id=32106
    - **Original**: https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-webrel-1870.binary.sx
- **App ID**: `32106`

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-webrel-1870.binary.sx/

@vinu-deriv vinu-deriv merged commit 81b8272 into deriv-com:master Jan 5, 2024
vinu-deriv pushed a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants