Skip to content

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Fixed CTrader completed transactions message to show either 'Transfer to' or 'Transfer from' depending on type of transfer
  • Updated direction logic based on longcode difference between CTrader and DerivX messages for this temporary workaround before backend adds to and from for Deriv X and CTrader transfers

Screenshots:

image Screenshot 2024-01-10 at 1 43 40 PM Screenshot 2024-01-10 at 1 44 13 PM

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 10, 2024 7:31am

Copy link
Contributor

github-actions bot commented Jan 10, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12869](https://github.com/binary-com/deriv-app/pull/12869)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3243-transactions-c-76a5c0.binary.sx?qa_server=red.derivws.com&app_id=38789
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3243-transactions-c-76a5c0.binary.sx
- **App ID**: `38789`

Copy link
Contributor

github-actions bot commented Jan 10, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3243-transactions-c-76a5c0.binary.sx/

@coveralls
Copy link

coveralls commented Jan 10, 2024

Coverage Status

coverage: 34.532%. remained the same
when pulling 191cf2e on lubega-deriv:WALL-3243/transactions-completed-transfer-from-fix
into 7f34999 on binary-com:master.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
22.3% Duplication on New Code

See analysis details on SonarCloud

@nijil-deriv nijil-deriv merged commit ea64fae into deriv-com:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants