Skip to content

Conversation

@farabi-deriv
Copy link
Contributor

@farabi-deriv farabi-deriv commented Jan 11, 2024

Changes:

  • Fix sidebar text on tutorials tab are getting overflown with translation
  • Fix import modal issue from bot builder import
  • FAQ title is missing also title not shown when search is active
  • Include all tutorial titles on search

@vercel
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 17, 2024 7:13am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12904](https://github.com/binary-com/deriv-app/pull/12904)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-1244fix-dbot-ui-bugs.binary.sx?qa_server=red.derivws.com&app_id=32806
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-1244fix-dbot-ui-bugs.binary.sx
- **App ID**: `32806`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-1244fix-dbot-ui-bugs.binary.sx/

@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 34.735% (+0.04%) from 34.699%
when pulling 217921c on farabi-deriv:farabi/bot-1244/fix--dbot-ui-bugs
into 1bd0b40 on binary-com:master.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
4.9% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@sandeep-deriv sandeep-deriv merged commit 3920c59 into deriv-com:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants