Skip to content

Conversation

@likhith-deriv
Copy link
Contributor

Changes:

Fix the build issue that occured due to incorrect variables and dead code.
Occured due to duplicate component

@vercel
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 12, 2024 7:28am

return true;
}
return !['pending', 'verified'].includes(authentication_status.document_status);
return isPOARequiredForMT5(account_status, jurisdiction_selected_shortcode);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likhith-deriv where do we use this file actually?

Copy link
Contributor Author

@likhith-deriv likhith-deriv Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. I have asked @shontzu-deriv regd the duplicate. Its part of their refactoring initiative. So for now I've added the changes that were done in the packages/cfd/src/Containers/cfd-financial-stp-real-account-signup.tsx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the files in the /features directly are not being used anywhere in prod, it was made during cfd refactoring and basically duplicate (and sometimes renamed) file , please refrain from modifying it where possible 🙏🏼

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@likhith-deriv likhith-deriv Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag 'authenticated_with_idv_photoid' u r using doesn't exist anymore as part of the COJ-210 clickup card. Hence I have updated the logic. Keeping the code causes build failure as the hook useIsAccountStatusPresent dosen't accept the flag as a valid param

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12926](https://github.com/binary-com/deriv-app/pull/12926)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-likhith-fix-build-issue-361a0d.binary.sx?qa_server=red.derivws.com&app_id=24056
    - **Original**: https://deriv-app-git-fork-likhith-deriv-likhith-fix-build-issue-361a0d.binary.sx
- **App ID**: `24056`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-fix-build-issue-361a0d.binary.sx/

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@likhith-deriv likhith-deriv merged commit 6952c30 into deriv-com:rc_V20240111_0 Jan 12, 2024
likhith-deriv added a commit that referenced this pull request Jan 12, 2024
* fix: build issues in staging

* fix: failing testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants