-
Notifications
You must be signed in to change notification settings - Fork 394
fix: build issues in staging #12926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build issues in staging #12926
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return true; | ||
| } | ||
| return !['pending', 'verified'].includes(authentication_status.document_status); | ||
| return isPOARequiredForMT5(account_status, jurisdiction_selected_shortcode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@likhith-deriv where do we use this file actually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. I have asked @shontzu-deriv regd the duplicate. Its part of their refactoring initiative. So for now I've added the changes that were done in the packages/cfd/src/Containers/cfd-financial-stp-real-account-signup.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the files in the /features directly are not being used anywhere in prod, it was made during cfd refactoring and basically duplicate (and sometimes renamed) file , please refrain from modifying it where possible 🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @mahdiyeh-deriv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag 'authenticated_with_idv_photoid' u r using doesn't exist anymore as part of the COJ-210 clickup card. Hence I have updated the logic. Keeping the code causes build failure as the hook useIsAccountStatusPresent dosen't accept the flag as a valid param
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-fix-build-issue-361a0d.binary.sx/ |
|
* fix: build issues in staging * fix: failing testcase

Changes:
Fix the build issue that occured due to incorrect variables and dead code.
Occured due to duplicate component