Skip to content

Conversation

@aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Jan 15, 2024

Changes:

  • Added checks for CFD if account is EU.
  • Added loading animation placeholder for CFD section
  • Added EU Disclaimer message
  • Added new values inside of tailwind config and remove unused values from the config file.

Screenshots:

image

image

@aizad-deriv aizad-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Jan 15, 2024
@aizad-deriv aizad-deriv self-assigned this Jan 15, 2024
@vercel
Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 15, 2024 4:34am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12936](https://github.com/binary-com/deriv-app/pull/12936)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-eu-traders-hub.binary.sx?qa_server=red.derivws.com&app_id=32225
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-eu-traders-hub.binary.sx
- **App ID**: `32225`

@coveralls
Copy link

coveralls commented Jan 15, 2024

Coverage Status

coverage: 34.662% (+0.006%) from 34.656%
when pulling fd720ac on aizad-deriv:aizad/eu-traders-hub
into 431d167 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-eu-traders-hub.binary.sx/

@aizad-deriv aizad-deriv changed the title [TRAH] Aizad/ Fix EU Loading Screen [TRAH] Aizad/ TRAH-2264/ EU disclaimer banner Jan 15, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mahdiyeh-deriv mahdiyeh-deriv merged commit e9ff716 into deriv-com:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants