Skip to content

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

Changes:

Because we do fetch as we need in wallet, if we spam and switch between accounts, it will cause rate limit in the legacy store. Here adding staleTime because these endpoints's response will not be updated unless we do some operations (like adding account(s) or switching account)

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 15, 2024 8:32am

@sweep-ai-deprecated
Copy link

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12947](https://github.com/binary-com/deriv-app/pull/12947)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-fix-rate-limit.binary.sx?qa_server=red.derivws.com&app_id=32113
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-fix-rate-limit.binary.sx
- **App ID**: `32113`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-fix-rate-limit.binary.sx/

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants