chore: update validation errors and regex #13032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
requested review from
amina-deriv,
maryia-deriv and
matin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
amina-deriv
approved these changes
Jan 18, 2024
heorhi-deriv
approved these changes
Jan 18, 2024
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-webrel1903-1905va-208814.binary.sx/ |
heorhi-deriv
pushed a commit
that referenced
this pull request
Jan 18, 2024
sandeep-deriv
added a commit
that referenced
this pull request
Jan 18, 2024
* Ako/ enable back the wa icon (#13026) * Revert "Ako/remove whats app icon (#13018)" This reverts commit 15ba3a6. * Revert "fix: to disable whatsapp icon from footer (#13011)" This reverts commit 16152c2. * [TRAH]/Hamza/trah 2673/compare accounts screen (#13027) * chore: added compare account screen * chore: fxed the button not showing + background * chore: fix mt5 created accounts for demo and real (#13023) * chore: update validation errors and regex (#13032) * translations: 📚 sync translations with crowdin (#13034) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * ci: add missing env vars (#13039) --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fix validation issue from account settings personal details.
Screenshots:
Please provide some screenshots of the change.