Skip to content

Conversation

@aum-deriv
Copy link
Contributor

@aum-deriv aum-deriv commented Feb 1, 2024

Changes:

Fixed the overlapping of the app-icon rendered in <WalletsAppLinkedWithWalletIcon /> by reordering the wallet-icon and the app-icon and removing the unreliable way of using z-index property from styles.

Screenshots:

SVID_20240124_145125_1.mp4

@vercel
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 7, 2024 8:12am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13298](https://github.com/binary-com/deriv-app/pull/13298)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-wall-3367fix-wallet-lin-6b6d1e.binary.sx?qa_server=red.derivws.com&app_id=32113
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-wall-3367fix-wallet-lin-6b6d1e.binary.sx
- **App ID**: `32113`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-3367fix-wallet-lin-6b6d1e.binary.sx/

@coveralls
Copy link

coveralls commented Feb 1, 2024

Coverage Status

coverage: 35.657% (+0.1%) from 35.527%
when pulling 0d69de9 on aum-deriv:aum/WALL-3367/fix-wallet-linked-app-icon-overlap-issue
into 1779ab7 on binary-com:master.

@aum-deriv aum-deriv changed the title [Draft] [WALL] aum / WALL-3367 / fix-wallet-linked-app-icon-overlap-issue [WALL] aum / WALL-3367 / fix-wallet-linked-app-icon-overlap-issue Feb 2, 2024
@aum-deriv aum-deriv marked this pull request as ready for review February 2, 2024 05:51
@aum-deriv aum-deriv requested a review from a user February 2, 2024 05:51
ghost
ghost previously approved these changes Feb 2, 2024
heorhi-deriv
heorhi-deriv previously approved these changes Feb 2, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
9.1% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit 494c887 into deriv-com:master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants