Skip to content

Conversation

@adrienne-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Added test cases for ad details in My profile page
Screenshot 2024-02-08 at 9 55 10 AM

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 8, 2024 2:18am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.7% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13435](https://github.com/binary-com/deriv-app/pull/13435)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-my-profile-ad-details.binary.sx?qa_server=red.derivws.com&app_id=31483
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-my-profile-ad-details.binary.sx
- **App ID**: `31483`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-p2p-v2-my-profile-ad-details.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 35.823% (+0.04%) from 35.78%
when pulling 7b47a5d on adrienne-deriv:p2p-v2-my-profile-ad-details
into 976bad0 on binary-com:master.

Copy link
Contributor

@jim-deriv jim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farrah-deriv farrah-deriv merged commit fd5b690 into deriv-com:master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants