[UPM-611] Suisin/upm611/change self exclusion learn more content #13437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
requested review from
amina-deriv,
maryia-deriv and
matin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
suisin-deriv
commented
Feb 8, 2024
| }, | ||
| ]; | ||
|
|
||
| if (is_uk) { |
There was a problem hiding this comment.
Removing the is_uk check in self_exclusion content since we are not supporting UK business anymore
suisin-deriv
commented
Feb 8, 2024
Comment on lines
-103
to
-135
| it('should render SelfExclusionArticleContent component for EU/UK items', () => { | ||
| mock_context.is_eu = true; | ||
| mock_context.is_uk = true; | ||
|
|
||
| render( | ||
| <SelfExclusionContext.Provider value={mock_context}> | ||
| <SelfExclusionArticleContent /> | ||
| </SelfExclusionContext.Provider> | ||
| ); | ||
|
|
||
| expect(screen.getByText(eu_item)).toBeInTheDocument(); | ||
| expect(screen.getByText(eu_uk_item)).toBeInTheDocument(); | ||
| expect(screen.getByText(not_app_settings_eu_uk_descr)).toBeInTheDocument(); | ||
| expect(screen.queryByText(non_eu_item)).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('should render SelfExclusionArticleContent component for EU/UK items with app settings', () => { | ||
| mock_context.is_app_settings = true; | ||
| mock_context.is_eu = true; | ||
| mock_context.is_uk = true; | ||
|
|
||
| render( | ||
| <SelfExclusionContext.Provider value={mock_context}> | ||
| <SelfExclusionArticleContent /> | ||
| </SelfExclusionContext.Provider> | ||
| ); | ||
|
|
||
| expect(screen.getByText(eu_item)).toBeInTheDocument(); | ||
| expect(screen.getByText(eu_uk_item)).toBeInTheDocument(); | ||
| expect(screen.queryByText(not_app_settings_eu_descr)).not.toBeInTheDocument(); | ||
| expect(screen.queryByText(not_app_settings_eu_uk_descr)).not.toBeInTheDocument(); | ||
| expect(screen.queryByText(non_eu_item)).not.toBeInTheDocument(); | ||
| }); |
There was a problem hiding this comment.
Removing test case for UK clients
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-upm611changeselfe-460c20.binary.sx/ |
thisyahlen-deriv
approved these changes
Feb 8, 2024
likhith-deriv
approved these changes
Feb 8, 2024
vinu-deriv
pushed a commit
to vinu-deriv/deriv-app
that referenced
this pull request
Feb 12, 2024
…iv-com#13437) * chore: update self exclusion pop up message * chore: update test case and remove unused items in self-exclusion-content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Change Self Exclusion Content message to follow the document: https://docs.google.com/document/d/1laQxwr-u7IDZu5h7nRlGjYKd37Wjgq0JhDwHZpSZ0Ig/edit
Screenshots:
ROW Users
EU Users
