[WALL] Lubega / WALL-2795 / Wallet account switcher #13473

lubega-deriv · 2024-02-09T02:57:53Z

Changes:

Updated wallet account switcher new design according to figma
Updated DesktopWalletsList logic to implement useActiveWalletAccount instead of useWalletAccountsList to display only the active wallet account
Renamed WalletsAccordion and WalletsAccordionLoader to WalletsCard and WalletsCardLoader
Updated WalletListCardTitle to WalletListCardDropdown
Added unit test for WalletListCardDropdown
Added optional props to WalletTextfield and WalletDropdown component to be used in WalletListCardDropdown
Added logic in WalletListCardDropdown to change dropdown length according to input value
Added icons for circular logos

Screenshots:

Screen.Recording.2024-02-09.at.10.41.53.AM.mov

vercel · 2024-02-09T02:57:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Feb 14, 2024 3:03am

github-actions · 2024-02-09T03:17:37Z

A production App ID was automatically generated for this PR. (log)

PR: [WALL] Lubega / WALL-2795 / Wallet account switcher #13473
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-lubega-deriv-wall-2795-wallet-account-9d5cb0.binary.sx?qa_server=red.derivws.com&app_id=31227
- Original: https://deriv-app-git-fork-lubega-deriv-wall-2795-wallet-account-9d5cb0.binary.sx
App ID: 31227

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/13473](https://github.com/binary-com/deriv-app/pull/13473)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-2795-wallet-account-9d5cb0.binary.sx?qa_server=red.derivws.com&app_id=31227
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-2795-wallet-account-9d5cb0.binary.sx
- **App ID**: `31227`

github-actions · 2024-02-09T03:18:02Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	28
🟧 Accessibility	89
🟢 Best practices	92
🟧 SEO	85
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-2795-wallet-account-9d5cb0.binary.sx/

coveralls · 2024-02-09T03:19:10Z

coverage: 36.21% (+0.2%) from 36.003%
when pulling fa56982 on lubega-deriv:WALL-2795/wallet-account-switcher
into 4d45200 on binary-com:master.

packages/wallets/src/components/Base/WalletTextField/WalletTextField.tsx

packages/wallets/src/components/WalletListCardDropdown/WalletListCardDropdown.scss

sonarqubecloud · 2024-02-14T02:44:33Z

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-02-14T03:04:00Z

⏳ Generating Lighthouse report...

* feat: wallet account switcher * fix: wallet card icon variants * fix: import sorting order * fix: import sorting order * fix: applied comments * fix: applied comments * fix: added missing dependency * fix: added usecallback for title text * fix: added usecallback for title text * fix: cleane up code * fix: updated component test

lubega-deriv added 2 commits February 9, 2024 10:49

feat: wallet account switcher

d6ad944

fix: wallet card icon variants

3b88806

lubega-deriv requested review from adrienne-deriv, farhan-nurzi-deriv and thisyahlen-deriv as code owners February 9, 2024 02:57

lubega-deriv requested a review from a user February 9, 2024 02:57

lubega-deriv requested review from aizad-deriv and heorhi-deriv as code owners February 9, 2024 02:57

lubega-deriv had a problem deploying to Preview February 9, 2024 02:58 — with GitHub Actions Failure

lubega-deriv temporarily deployed to Preview February 9, 2024 02:58 — with GitHub Actions Inactive

fix: import sorting order

fed886c

lubega-deriv had a problem deploying to Preview February 9, 2024 03:20 — with GitHub Actions Failure

lubega-deriv temporarily deployed to Preview February 9, 2024 03:20 — with GitHub Actions Inactive

fix: import sorting order

03acd27

lubega-deriv had a problem deploying to Preview February 9, 2024 03:47 — with GitHub Actions Failure

lubega-deriv temporarily deployed to Preview February 9, 2024 03:48 — with GitHub Actions Inactive

ghost reviewed Feb 9, 2024

View reviewed changes

packages/wallets/src/components/Base/WalletTextField/WalletTextField.tsx Outdated Show resolved Hide resolved

ghost reviewed Feb 9, 2024

View reviewed changes

packages/wallets/src/components/WalletListCardDropdown/WalletListCardDropdown.scss Outdated Show resolved Hide resolved

fix: applied comments

5be8457

lubega-deriv temporarily deployed to Preview February 12, 2024 11:20 — with GitHub Actions Inactive

fix: applied comments

83f78f4

lubega-deriv temporarily deployed to Preview February 12, 2024 11:39 — with GitHub Actions Inactive

fix: added missing dependency

f92e5f1

lubega-deriv temporarily deployed to Preview February 13, 2024 01:48 — with GitHub Actions Inactive

fix: added usecallback for title text

73c3d82

lubega-deriv had a problem deploying to Preview February 13, 2024 02:38 — with GitHub Actions Failure

lubega-deriv temporarily deployed to Preview February 13, 2024 02:38 — with GitHub Actions Inactive

fix: added usecallback for title text

44590a0

lubega-deriv had a problem deploying to Preview February 13, 2024 03:24 — with GitHub Actions Failure

lubega-deriv temporarily deployed to Preview February 13, 2024 03:24 — with GitHub Actions Inactive

fix: cleane up code

7675501

lubega-deriv had a problem deploying to Preview February 13, 2024 12:57 — with GitHub Actions Failure

lubega-deriv temporarily deployed to Preview February 13, 2024 12:58 — with GitHub Actions Inactive

fix: updated component test

fa56982

lubega-deriv temporarily deployed to Preview February 14, 2024 02:43 — with GitHub Actions Inactive

ghost approved these changes Feb 14, 2024

View reviewed changes

nijil-deriv approved these changes Feb 14, 2024

View reviewed changes

nijil-deriv merged commit 440491f into deriv-com:master Feb 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WALL] Lubega / WALL-2795 / Wallet account switcher #13473

[WALL] Lubega / WALL-2795 / Wallet account switcher #13473

Uh oh!

lubega-deriv commented Feb 9, 2024 •

edited

Loading

Uh oh!

vercel bot commented Feb 9, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Feb 9, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Feb 9, 2024 •

edited

Loading

Uh oh!

coveralls commented Feb 9, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 14, 2024

Uh oh!

github-actions bot commented Feb 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[WALL] Lubega / WALL-2795 / Wallet account switcher #13473

[WALL] Lubega / WALL-2795 / Wallet account switcher #13473

Uh oh!

Conversation

lubega-deriv commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Screenshots:

Uh oh!

vercel bot commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 14, 2024

Quality Gate passed

Uh oh!

github-actions bot commented Feb 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lubega-deriv commented Feb 9, 2024 •

edited

Loading

vercel bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

coveralls commented Feb 9, 2024 •

edited

Loading