Skip to content

Conversation

farrah-deriv
Copy link
Contributor

Changes:

Moved the declaration of order info inside the component to re-render when switching language.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 13, 2024 11:58am

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
5.9% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13524](https://github.com/binary-com/deriv-app/pull/13524)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farrah-deriv-p2ps-2361-order-info-tra-aafee5.binary.sx?qa_server=red.derivws.com&app_id=24070
    - **Original**: https://deriv-app-git-fork-farrah-deriv-p2ps-2361-order-info-tra-aafee5.binary.sx
- **App ID**: `24070`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farrah-deriv-p2ps-2361-order-info-tra-aafee5.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 36.061% (+0.008%) from 36.053%
when pulling fde3c96 on farrah-deriv:P2PS-2361/order-info-translation
into 60a817f on binary-com:master.

@farrah-deriv farrah-deriv merged commit ebccbd2 into deriv-com:master Feb 16, 2024
sergei-deriv pushed a commit to sergei-deriv/deriv-app that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants