Skip to content

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Remove additional quill tailwind config styles
  2. Created AppContainer

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Feb 14, 2024
@thisyahlen-deriv thisyahlen-deriv self-assigned this Feb 14, 2024
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 14, 2024 4:44am

Copy link
Contributor

github-actions bot commented Feb 14, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13535](https://github.com/binary-com/deriv-app/pull/13535)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-removequi-a1d49c.binary.sx?qa_server=red.derivws.com&app_id=31528
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-removequi-a1d49c.binary.sx
- **App ID**: `31528`

Copy link
Contributor

github-actions bot commented Feb 14, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-removequi-a1d49c.binary.sx/

@coveralls
Copy link

coveralls commented Feb 14, 2024

Coverage Status

coverage: 36.115% (-0.002%) from 36.117%
when pulling a2e0ecd on thisyahlen-deriv:thisyahlen/remove_quill_base_tailwind_part_2
into 472c26d on binary-com:master.

shahzaib-deriv
shahzaib-deriv previously approved these changes Feb 14, 2024
Copy link
Contributor Author

@thisyahlen-deriv thisyahlen-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mahdiyeh-deriv mahdiyeh-deriv merged commit 15e1d80 into deriv-com:master Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants