Skip to content

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Feb 20, 2024

Changes:

  • Updated description video config and trading-categories-gif.tsx by adding IDs for Rise/Fall, Higher/Lower, Touch/To Touch and refreshing for Accumulators.
  • Removed old icons.
  • Updated tests

Screenshots:

Screenshot 2024-02-20 at 14 59 33 Screenshot 2024-02-20 at 14 58 32

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 1, 2024 8:21am

Copy link
Contributor

github-actions bot commented Feb 20, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13706](https://github.com/binary-com/deriv-app/pull/13706)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-774addvideotutorials.binary.sx?qa_server=red.derivws.com&app_id=31229
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-774addvideotutorials.binary.sx
- **App ID**: `31229`

Copy link
Contributor

github-actions bot commented Feb 20, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-774addvideotutorials.binary.sx/

@coveralls
Copy link

coveralls commented Feb 20, 2024

Coverage Status

coverage: 37.336% (-0.005%) from 37.341%
when pulling e6e1b33 on kate-deriv:kate/DTRA-774/add_video_tutorials
into 74d8136 on binary-com:master.

maryia-deriv
maryia-deriv previously approved these changes Feb 20, 2024
maryia-deriv
maryia-deriv previously approved these changes Feb 21, 2024
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
4.8% Duplication on New Code

See analysis details on SonarCloud

@maryia-deriv maryia-deriv merged commit 1186870 into deriv-com:master Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants