Suisin/chore: remove quill components and refactor tailwind classnames #13801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
requested review from
balakrishna-deriv and
yashim-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thisyahlen-deriv
previously approved these changes
Feb 27, 2024
Contributor
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Contributor
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-refactoraccountv2-b79109.binary.sx/ |
|
shahzaib-deriv
requested changes
Feb 27, 2024
| <ManualFormFooter /> | ||
| </div> | ||
| <div className='sticky bottom-50 flex justify-end gap-800 bg-vp px-400 py-800 border-t-solid-grey-2 bg-solid-slate-50 border-solid border-t-100'> | ||
| <div className='sticky bottom-0 flex justify-end gap-16 px-8 py-16 border-t-solid-grey-2 bg-solid-slate-0 border-solid border-t-2'> |
Contributor
There was a problem hiding this comment.
we need to refactor the footers not to use any position property rather than using flex
Using position messes up the height and we have to define the offsets to compensate
Contributor
Author
There was a problem hiding this comment.
We will do this later
Contributor
There was a problem hiding this comment.
Please add a TODO so we dont miss this
packages/account-v2/src/containers/POAForm/DocumentSubmission/DocumentSubmission.tsx
Show resolved
Hide resolved
packages/account-v2/src/containers/POAForm/DocumentSubmission/DocumentSubmission.tsx
Show resolved
Hide resolved
thisyahlen-deriv
approved these changes
Feb 27, 2024
shahzaib-deriv
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Remove quill components and refactor tailwind classnames
Screenshots:
Please provide some screenshots of the change.