Skip to content

Conversation

@farabi-deriv
Copy link
Contributor

@farabi-deriv farabi-deriv commented Feb 28, 2024

Changes:

  • Dark mode improvements for quick strategies on tutorials tab
  • Highlighted the border of search bar on tutorial when active

Screenshots:

Screenshot 2024-02-28 at 3 51 54 PM

@vercel
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 29, 2024 7:40am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13863](https://github.com/binary-com/deriv-app/pull/13863)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-530active-sea-e9c9f5.binary.sx?qa_server=red.derivws.com&app_id=24189
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-530active-sea-e9c9f5.binary.sx
- **App ID**: `24189`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-530active-sea-e9c9f5.binary.sx/

@maryia-matskevich-deriv
Copy link
Contributor

@farabi-deriv it looks like the default background color of the input field should be a different color according to the design link. Please correct me if I'm wrong. I haven't found any other option for default color behavior. Kindly please check it 🙏

Screenshot 2024-02-28 at 16 56 09

sandeep-deriv
sandeep-deriv previously approved these changes Feb 28, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
8.4% Duplication on New Code

See analysis details on SonarCloud

@sandeep-deriv sandeep-deriv merged commit c99d61a into deriv-com:master Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants