-
Notifications
You must be signed in to change notification settings - Fork 394
Fix nx dependencies issue #13884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nx dependencies issue #13884
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-test-nx.binary.sx/ |
|
| }, | ||
| "nx": { | ||
| "implicitDependencies": [ | ||
| "@deriv/api" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sure that account-v2 is only built when @deriv/api has already been run and build by nx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think due to the nature of nx parallel runs when we run nx run-many, the build orders are not consistent, thus @deriv/api may not be built yet before account-v2 is run and symlinked to the dependent packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm haven't tried that before 🤔
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed. |





Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.