Skip to content

Conversation

@adrienne-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 29, 2024 5:57am

@adrienne-deriv adrienne-deriv marked this pull request as ready for review February 29, 2024 03:51
@adrienne-deriv adrienne-deriv changed the title Test nx Test nx dependencies issue Feb 29, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13884](https://github.com/binary-com/deriv-app/pull/13884)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-test-nx.binary.sx?qa_server=red.derivws.com&app_id=24195
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-test-nx.binary.sx
- **App ID**: `24195`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-test-nx.binary.sx/

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
20.3% Duplication on New Code

See analysis details on SonarCloud

@adrienne-deriv adrienne-deriv changed the title Test nx dependencies issue Fix nx dependencies issue Feb 29, 2024
},
"nx": {
"implicitDependencies": [
"@deriv/api"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sure that account-v2 is only built when @deriv/api has already been run and build by nx

Copy link
Contributor Author

@adrienne-deriv adrienne-deriv Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think due to the nature of nx parallel runs when we run nx run-many, the build orders are not consistent, thus @deriv/api may not be built yet before account-v2 is run and symlinked to the dependent packages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why if we just put @deriv/api first in the build command before run-many 🙂
image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm haven't tried that before 🤔

@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2024

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

@github-actions github-actions bot closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants