Skip to content

Conversation

@shahzaib-deriv
Copy link
Contributor

Changes:

  • Updated the regular expression for address_postcode to disallow spaces at the start.
  • Added a new test case to verify the updated validation check for address_postcode.

Testing

  • The new test case has been added to the existing suite of tests and has been confirmed to pass successfully, verifying the correct functionality of the updated validation check.
Screen.Recording.2024-02-29.at.1.55.01.PM.mov

@vercel
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 13, 2024 4:08am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13896](https://github.com/binary-com/deriv-app/pull/13896)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-trah-2983post-zip-code-7e8747.binary.sx?qa_server=red.derivws.com&app_id=32113
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-trah-2983post-zip-code-7e8747.binary.sx
- **App ID**: `32113`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-trah-2983post-zip-code-7e8747.binary.sx/

address_line_1: /^[\p{L}\p{Nd}\s'.,:;()\u00b0@#/-]{1,70}$/u,
address_line_2: /^[\p{L}\p{Nd}\s'.,:;()\u00b0@#/-]{0,70}$/u,
address_postcode: /^[a-zA-Z0-9\s-]{0,20}$/,
address_postcode: /^(?! )[a-zA-Z0-9\s-]{0,20}$/,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the regex to disallow space in the beginning

@coveralls
Copy link

coveralls commented Mar 8, 2024

Coverage Status

coverage: 38.064% (+0.008%) from 38.056%
when pulling 69fe0ac on shahzaib-deriv:TRAH-2983_post-zip-code-validation
into 3d42a1d on binary-com:master.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@mahdiyeh-deriv mahdiyeh-deriv merged commit e3c41be into deriv-com:master Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants