Skip to content

Conversation

@ali-hosseini-deriv
Copy link
Contributor

Changes:

This is to separate github cache and npm ci commands.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 29, 2024 6:53am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13900](https://github.com/binary-com/deriv-app/pull/13900)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-fix-gh-cache-issue.binary.sx?qa_server=red.derivws.com&app_id=23852
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-fix-gh-cache-issue.binary.sx
- **App ID**: `23852`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-fix-gh-cache-issue.binary.sx/

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ali-hosseini-deriv ali-hosseini-deriv merged commit bbe67a3 into deriv-com:master Feb 29, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
14.7% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Feb 29, 2024

Coverage Status

coverage: 36.96%. remained the same
when pulling 04dae5b on ali-hosseini-deriv:ako/fix-gh-cache-issue
into 9e78e2d on binary-com:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants