Skip to content

Conversation

jim-deriv
Copy link
Contributor

@jim-deriv jim-deriv commented Mar 21, 2024

Changes:

  • Updated all usages of the env. or inputs. syntax to $
  • Removed the step for setting up environment variables

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 19, 2024 6:45am

Copy link
Contributor

github-actions bot commented Mar 21, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14295](https://github.com/binary-com/deriv-app/pull/14295)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-dsec-25496risky-context-29675c.binary.sx?qa_server=red.derivws.com&app_id=23888
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-dsec-25496risky-context-29675c.binary.sx
- **App ID**: `23888`

Copy link
Contributor

github-actions bot commented Mar 21, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-dsec-25496risky-context-29675c.binary.sx/

@coveralls
Copy link

coveralls commented Mar 21, 2024

Coverage Status

coverage: 40.124% (-0.001%) from 40.125%
when pulling b9b784c on jim-deriv:jim/dsec-25496/risky-contexts-in-deriv-app
into 3a45f91 on binary-com:master.

@jim-deriv jim-deriv marked this pull request as ready for review March 21, 2024 07:00
Copy link

@ritik-deriv ritik-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ali-hosseini-deriv ali-hosseini-deriv merged commit fc1c420 into deriv-com:master Apr 24, 2024
@jim-deriv jim-deriv deleted the jim/dsec-25496/risky-contexts-in-deriv-app branch September 19, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants