Skip to content

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Update cfd chevron design as per discussion and figma reference
  • Fix design for account badge
  • Revert usage of isLoading to isFetchedAfterMount for useSortedMT5Accounts

Screenshots:

Screen.Recording.2024-04-16.at.2.28.04.PM.mov
Screen.Recording.2024-04-16.at.2.28.58.PM.mov

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 16, 2024 9:10am

@coveralls
Copy link

coveralls commented Apr 16, 2024

Coverage Status

coverage: 40.026% (-0.03%) from 40.052%
when pulling 5989f2c on lubega-deriv:WALL-3745/cfd-chevron-design-fixes
into 32029a6 on binary-com:master.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14631](https://github.com/binary-com/deriv-app/pull/14631)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3745-cfd-chevron-de-90fdf4.binary.sx?qa_server=red.derivws.com&app_id=24045
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3745-cfd-chevron-de-90fdf4.binary.sx
- **App ID**: `24045`

Copy link
Contributor

github-actions bot commented Apr 16, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3745-cfd-chevron-de-90fdf4.binary.sx/

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants