Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2024

Updated useRemoteConfig hook as it diverged, in order to help removal of legacy bits of code (/packages/api)

No QA required as this bit of code is not used on prod code (if at all).

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 29, 2024 3:52pm

@ghost ghost temporarily deployed to Preview April 29, 2024 15:28 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview April 29, 2024 15:29 — with GitHub Actions Inactive
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14887](https://github.com/binary-com/deriv-app/pull/14887)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-wojciech-deriv-feature-wall-3920.binary.sx?qa_server=red.derivws.com&app_id=23813
    - **Original**: https://deriv-app-git-fork-wojciech-deriv-feature-wall-3920.binary.sx
- **App ID**: `23813`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 25
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-wojciech-deriv-feature-wall-3920.binary.sx/

@ghost
Copy link
Author

ghost commented Apr 30, 2024

closing, no longer relevant,

@ghost ghost closed this Apr 30, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants