Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 3, 2024

Fixed scenario in which TransactionStatus resubscribes before reopened connection is authorized and thus errors out.

Separately, there is upcoming PR to fix the problem with reconnection itself - sometimes it does not reconnect properly when tab is asleep in background.

@vercel
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview May 3, 2024 9:15am

@ghost ghost temporarily deployed to Preview May 3, 2024 08:45 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 3, 2024 08:46 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.4% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented May 3, 2024

Coverage Status

coverage: 40.528% (+0.002%) from 40.526%
when pulling de35202 on wojciech-deriv:feature/fix-transation-status
into 5347915 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14967](https://github.com/binary-com/deriv-app/pull/14967)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-wojciech-deriv-feature-fix-transation-status.binary.sx?qa_server=red.derivws.com&app_id=31387
    - **Original**: https://deriv-app-git-fork-wojciech-deriv-feature-fix-transation-status.binary.sx
- **App ID**: `31387`

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-wojciech-deriv-feature-fix-transation-status.binary.sx/

@ghost
Copy link
Author

ghost commented May 3, 2024

closing, in favour of more better solution

@ghost ghost closed this May 3, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant