Skip to content

[CFDS] Hasan/CFDS-3999/ Create a New password modal re-appears on Manage account settings #15042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[CFDS] Hasan/CFDS-3999/ Create a New password modal re-appears on Manage account settings #15042

wants to merge 7 commits into from

Conversation

@hasan-deriv
Copy link
Contributor

@hasan-deriv hasan-deriv commented May 8, 2024 •
edited
Loading

Changes:

  • Fixed re-appearing new password modal in account settings.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented May 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview May 28, 2024 8:09am

@boring-cyborg boring-cyborg bot added the Core label May 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/15042](https://github.com/binary-com/deriv-app/pull/15042)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hasan-deriv-hasan-mt5-password-flow.binary.sx?qa_server=red.derivws.com&app_id=30361
    - **Original**: https://deriv-app-git-fork-hasan-deriv-hasan-mt5-password-flow.binary.sx
- **App ID**: `30361`

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-hasan-deriv-hasan-mt5-password-flow.binary.sx/

@coveralls
Copy link

coveralls commented May 8, 2024 •
edited
Loading

Coverage Status

coverage: 42.159%. remained the same
when pulling 055147d on hasan-deriv:hasan/mt5-password-flow
into 890c12f on binary-com:master.

@hasan-deriv hasan-deriv changed the title fix: password modal re-trigger [WALL] Hasan/WALL-3803/ Create a New password modal re-appears on Manage account settings May 8, 2024
@hasan-deriv hasan-deriv marked this pull request as ready for review May 8, 2024 08:07
hirad-deriv
hirad-deriv previously approved these changes May 8, 2024
View reviewed changes
@aizad-deriv aizad-deriv mentioned this pull request May 8, 2024
Closed
nijil-deriv
nijil-deriv previously approved these changes May 16, 2024
View reviewed changes
ghost
ghost previously approved these changes May 17, 2024
View reviewed changes
nijil-deriv
nijil-deriv reviewed May 17, 2024
View reviewed changes
packages/core/src/App/Containers/Redirect/redirect.jsx Outdated
// The if statement is needed because the modal from core is triggered by the stores.
// Whereas the one in wallet is triggered by the hooks.
// This is to prevent the modal from being triggered twice.
if (!routes.wallets) setResetTradingPasswordModalOpen(true);
Copy link
Contributor

@nijil-deriv nijil-deriv May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remembered, we're removing /wallets and making / the route for wallets. We might need another approach to fix this.

aizad-deriv
aizad-deriv previously approved these changes May 20, 2024
View reviewed changes
@hasan-deriv hasan-deriv changed the title [WALL] Hasan/WALL-3803/ Create a New password modal re-appears on Manage account settings [CFDS] Hasan/CFDS-3999/ Create a New password modal re-appears on Manage account settings May 24, 2024
@hasan-deriv hasan-deriv dismissed stale reviews from aizad-deriv, ghost , nijil-deriv, and hirad-deriv via 6b54659 May 24, 2024 03:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2024

⏳ Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nijil-deriv nijil-deriv nijil-deriv left review comments

@hirad-deriv hirad-deriv hirad-deriv left review comments

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

+4 more reviewers

@shontzu-deriv shontzu-deriv shontzu-deriv approved these changes

@aum-deriv aum-deriv aum-deriv approved these changes

@aizad-deriv aizad-deriv aizad-deriv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hasan-deriv @coveralls @nijil-deriv @hirad-deriv @aizad-deriv @shontzu-deriv @aum-deriv @farrah-deriv