Skip to content

Conversation

ghost
Copy link

@ghost ghost commented May 16, 2024

Removed zxcvbn dictionary from deriv-app. Saving 1mb on at least two packages.
Downside is, that we no longer have the "common password" detection.

Screenshot 2024-05-21 at 14 25 15
Screenshot 2024-05-21 at 14 26 20

Gzipped:
Screenshot 2024-05-21 at 14 37 00
Screenshot 2024-05-21 at 14 37 26

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview May 21, 2024 2:05pm

@ghost ghost temporarily deployed to Preview May 16, 2024 14:14 — with GitHub Actions Inactive
@ghost ghost had a problem deploying to Preview May 16, 2024 14:14 — with GitHub Actions Failure
@ghost ghost temporarily deployed to Preview May 16, 2024 14:15 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented May 16, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15206](https://github.com/binary-com/deriv-app/pull/15206)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-wojciech-deriv-feature-remove-rap-lib-8f207b.binary.sx?qa_server=red.derivws.com&app_id=24202
    - **Original**: https://deriv-app-git-fork-wojciech-deriv-feature-remove-rap-lib-8f207b.binary.sx
- **App ID**: `24202`

Copy link
Contributor

github-actions bot commented May 16, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 25
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-wojciech-deriv-feature-remove-rap-lib-8f207b.binary.sx/

@coveralls
Copy link

coveralls commented May 16, 2024

Coverage Status

coverage: 42.505% (+0.04%) from 42.466%
when pulling e732069 on wojciech-deriv:feature/remove-rap-library-vocabulary
into 488058e on binary-com:master.

@ghost ghost temporarily deployed to Preview May 17, 2024 09:13 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 17, 2024 09:14 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 17, 2024 09:14 — with GitHub Actions Inactive
@ghost ghost changed the title [DRAFT][WALL-4040] removed dictionary from rap library [WALL-4092] removed dictionary from rap library May 17, 2024
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

nijil-deriv
nijil-deriv previously approved these changes May 20, 2024
@dan-deriv
Copy link
Contributor

What is the improvement for zipped traffic?

@dan-deriv
Copy link
Contributor

@wojciech-deriv should not we do the same for all apps?

markw-deriv
markw-deriv previously approved these changes May 20, 2024
@ghost ghost dismissed stale reviews from markw-deriv and nijil-deriv via 0bd4b0f May 20, 2024 17:29
@ghost ghost had a problem deploying to Preview May 21, 2024 08:55 — with GitHub Actions Failure
@ghost ghost had a problem deploying to Preview May 21, 2024 08:55 — with GitHub Actions Failure
@ghost ghost temporarily deployed to Preview May 21, 2024 08:55 — with GitHub Actions Inactive
@ghost ghost had a problem deploying to Preview May 21, 2024 09:05 — with GitHub Actions Failure
@ghost ghost temporarily deployed to Preview May 21, 2024 09:05 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 21, 2024 09:05 — with GitHub Actions Inactive
@ghost ghost had a problem deploying to Preview May 21, 2024 09:36 — with GitHub Actions Failure
@ghost ghost temporarily deployed to Preview May 21, 2024 09:36 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 21, 2024 09:37 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 21, 2024 10:52 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 21, 2024 10:52 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 21, 2024 10:53 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 21, 2024 11:02 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 21, 2024 11:02 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 21, 2024 11:02 — with GitHub Actions Inactive
@ghost ghost changed the title [WALL-4092] removed dictionary from rap library [WALL-4040] removed dictionary from rap library May 21, 2024
@ghost
Copy link
Author

ghost commented May 21, 2024

@wojciech-deriv should not we do the same for all apps?

hey @dan-deriv , updated PR to remove it from all packages + added screenshots of before/after, normal and gzipped

Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
5.8% Duplication on New Code

See analysis details on SonarCloud

@ghost ghost temporarily deployed to Preview May 21, 2024 13:53 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented May 21, 2024

Generating Lighthouse report...

@ghost ghost temporarily deployed to Preview May 21, 2024 14:07 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview May 21, 2024 14:08 — with GitHub Actions Inactive
@ghost
Copy link
Author

ghost commented May 22, 2024

as per technical discoveries, while desired to actually remove it, its only impactfull on certain rare user journeys, so sadly closing for now (sadly, as everyone is waiting to get rid of this and quite a lot of work went there)

@ghost ghost closed this May 22, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants