Skip to content

Conversation

@shahzaib-deriv
Copy link
Contributor

Changes:

  • When a client tries to create a duplicate account, the client will be notified via a pop-up message that similar details exist in our system.
  • Design update for error message pop up

Screenshots:

Screenshot 2024-05-20 at 1 49 27 PM Screenshot 2024-05-20 at 1 49 38 PM

@vercel
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 4, 2024 2:53am

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15247](https://github.com/binary-com/deriv-app/pull/15247)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-trah-3031duplicate-acc-cf4fe1.binary.sx?qa_server=red.derivws.com&app_id=32109
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-trah-3031duplicate-acc-cf4fe1.binary.sx
- **App ID**: `32109`

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-trah-3031duplicate-acc-cf4fe1.binary.sx/

habib-deriv
habib-deriv previously approved these changes May 21, 2024
@coveralls
Copy link

coveralls commented May 27, 2024

Coverage Status

coverage: 43.057% (-0.001%) from 43.058%
when pulling 16be272 on shahzaib-deriv:TRAH-3031_duplicate-account-error-messages
into 6e8fc27 on binary-com:master.

Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Generating Lighthouse report...

@habib-deriv habib-deriv merged commit 159e489 into deriv-com:master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants