Skip to content

Conversation

@aum-deriv
Copy link
Contributor

Changes:

  • Add more unit tests for WalletCashierHeader component

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 10, 2024 2:35pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15583](https://github.com/binary-com/deriv-app/pull/15583)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-wall-2962unit-tests-for-c6a431.binary.sx?qa_server=red.derivws.com&app_id=24165
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-wall-2962unit-tests-for-c6a431.binary.sx
- **App ID**: `24165`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-2962unit-tests-for-c6a431.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 43.534% (+0.003%) from 43.531%
when pulling 2593fa9 on aum-deriv:aum/WALL-2962/unit-tests-for-WalletCashierHeader
into 63894c6 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 43.516% (-0.02%) from 43.531%
when pulling 2593fa9 on aum-deriv:aum/WALL-2962/unit-tests-for-WalletCashierHeader
into 63894c6 on binary-com:master.

ghost
ghost previously approved these changes Jun 10, 2024
@coveralls
Copy link

Coverage Status

coverage: 43.52% (-0.01%) from 43.531%
when pulling f8566bd on aum-deriv:aum/WALL-2962/unit-tests-for-WalletCashierHeader
into 63894c6 on binary-com:master.

…Header/__tests__/WalletCashierHeader.spec.tsx

Co-authored-by: Nijil Nirmal <62882794+nijil-deriv@users.noreply.github.com>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 43.031% (-0.5%) from 43.531%
when pulling f061bbb on aum-deriv:aum/WALL-2962/unit-tests-for-WalletCashierHeader
into 63894c6 on binary-com:master.

@nijil-deriv nijil-deriv merged commit b282e32 into deriv-com:master Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants