Skip to content

Conversation

@fasihali-deriv
Copy link
Contributor

Changes:

Fixed tablet view spacing issue

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@vercel
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 2, 2024 10:50am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15920](https://github.com/binary-com/deriv-app/pull/15920)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-fasihali-deriv-fix-spacing-issue-tablet-view.binary.sx?qa_server=red.derivws.com&app_id=32820
    - **Original**: https://deriv-app-git-fork-fasihali-deriv-fix-spacing-issue-tablet-view.binary.sx
- **App ID**: `32820`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-fasihali-deriv-fix-spacing-issue-tablet-view.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 44.937% (+0.002%) from 44.935%
when pulling fbb152c on fasihali-deriv:fix-spacing-issue-tablet-view
into 5da908e on binary-com:master.

@likhith-deriv likhith-deriv merged commit 1eb15ed into deriv-com:master Jul 2, 2024
likhith-deriv pushed a commit that referenced this pull request Jul 2, 2024
Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants