Skip to content

Conversation

farabi-deriv
Copy link
Contributor

Changes:

  • Fixed the issue where transactions detail modal was not scrolling on firefox browser upon dragging or resizing the modal

Screenshots:

Screen.Recording.2024-07-04.at.3.19.30.PM.mov

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 4, 2024 8:58am

Copy link
Contributor

github-actions bot commented Jul 4, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15957](https://github.com/binary-com/deriv-app/pull/15957)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-1723unable-to-86ffe1.binary.sx?qa_server=red.derivws.com&app_id=32925
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-1723unable-to-86ffe1.binary.sx
- **App ID**: `32925`

Copy link
Contributor

github-actions bot commented Jul 4, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-1723unable-to-86ffe1.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 45.31%. remained the same
when pulling fb5cad0 on farabi-deriv:farabi/bot-1723/unable-to-scroll-txn-details-modal-on-firefox
into 6966640 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.314% (+0.004%) from 45.31%
when pulling 88555a2 on farabi-deriv:farabi/bot-1723/unable-to-scroll-txn-details-modal-on-firefox
into 6966640 on binary-com:master.

@sandeep-deriv sandeep-deriv merged commit cede7c1 into deriv-com:master Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants