Skip to content

[DTRA-1306] DTRA/DTrader V2 Position and contract details fixes #16149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 27, 2024
Merged

[DTRA-1306] DTRA/DTrader V2 Position and contract details fixes #16149

merged 13 commits into from
Aug 27, 2024

Conversation

@balakrishna-deriv
Copy link
Contributor

@balakrishna-deriv balakrishna-deriv commented Jul 22, 2024

Changes:

DTrader V2 - Position and contract details fixes

Screenshots:

Please provide some screenshots of the change.

ahmadtaimoor-deriv and others added 4 commits July 22, 2024 17:14
@ahmadtaimoor-deriv
Ahmad/DTRA-1408/Fix Vanilla Contract in Contract Details V2 (#16018)
1898af5 
* fix: decimal point

* fix: currency in payoutperpoint

* fix: vanillas

* fix: only vanilla

* fix: test coverage
@ahmadtaimoor-deriv
Ahmad/DTRA-1405/Multipliers fix on Contract Details V2 (#16017)
9ce45a0 
* fix: multiplier

* fix: testcase

* fix: fix

* fix: deal cancel

* chore: add DC

* chore: suggestion

* chore:fix

* fix: test case fix
@ahmadtaimoor-deriv @balakrishna-deriv
Ahmad/DTRA-1401/DTRA-1402/Add currency in payout per point and decima…
c42c12f 
…l point in take profit (#16012)

* fix: decimal point

* fix: currency in payoutperpoint

* fix: vanillas

* fix: test case and comments

* chore: review fix

* fix: indent

---------

Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com>
@kate-deriv @balakrishna-deriv
fix: bugs with resetting filter and icon for hight low (#16003)
7198696 
Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 26, 2024 3:53am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/16149](https://github.com/binary-com/deriv-app/pull/16149)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-position-and-contract-details-fixes.binary.sx?qa_server=red.derivws.com&app_id=32942
    - **Original**: https://deriv-app-git-position-and-contract-details-fixes.binary.sx
- **App ID**: `32942`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-position-and-contract-details-fixes.binary.sx/

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024

package old new diff pct change
account 186 KB 186 KB +17 B +0.0% 🟢
appstore 772 KB 772 KB 0 B 0% 🟢
bot-web-ui 842 KB 842 KB +6 B +0.0% 🟢
cashier 716 KB 716 KB 0 B 0% 🟢
cashier-v2 3.1 MB 3.1 MB 0 B 0% 🟢
cfd 135 KB 135 KB 0 B 0% 🟢
core 6.7 MB 6.7 MB +3 KB +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 95 KB 95 KB 0 B 0% 🟢
trader 379 KB 379 KB +214 B +0.1% 🟢
wallets 3.7 MB 3.7 MB --1 B −-0.0% 🟢

@coveralls
Copy link

coveralls commented Jul 22, 2024 •
edited
Loading

Coverage Status

coverage: 46.759% (+0.01%) from 46.746%
when pulling 94f1735 on position-and-contract-details-fixes
into b44aefc on master.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2024

package old new diff pct change
account 186 KB 186 KB --224 B −-0.1% 🟢
appstore 774 KB 772 KB --1169 B −-0.1% 🟢
bot-web-ui 682 KB 842 KB +161 KB +23.54% 🔴
cashier 718 KB 716 KB --2897 B −-0.4% 🟢
cashier-v2 3.1 MB 3.1 MB +15 KB +0.5% 🟢
cfd 136 KB 135 KB --479 B −-0.3% 🟢
core 6.7 MB 6.7 MB --11394 B −-0.2% 🟢
p2p 1.0 MB 1.0 MB --15063 B −-1.4% 🟢
reports 95 KB 95 KB --15 B −-0.0% 🟢
trader 443 KB 379 KB --64944 B −-14.32% 🟢
wallets 3.8 MB 3.7 MB --19283 B −-0.5% 🟢

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2024

package old new diff pct change
account 186 KB 186 KB 0 B 0% 🟢
appstore 774 KB 774 KB 0 B 0% 🟢
bot-web-ui 682 KB 682 KB +11 B +0.0% 🟢
cashier 718 KB 718 KB 0 B 0% 🟢
cashier-v2 3.1 MB 3.1 MB --1 B −-0.0% 🟢
cfd 136 KB 136 KB 0 B 0% 🟢
core 6.7 MB 6.7 MB +23 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 95 KB 95 KB 0 B 0% 🟢
trader 443 KB 443 KB +203 B +0.0% 🟢
wallets 3.8 MB 3.8 MB 0 B 0% 🟢

@akmal-deriv
Akmal / fix: pass currency across closed positions and contract detai…
640cde4 
…ls (#16161)

* fix: pass currency across closed positions and contract details

* fix: add a comment
@ahmadtaimoor-deriv
[DTRA]/Ahmad/DTRA-1490/Deal Cancellation Status Fix Trader-V2 (#16121)
b5bcb99 
* fix: cancellation active, executed and expired

* chore: revert last commit
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024

package old new diff pct change
account 191 KB 191 KB 0 B 0% 🟢
appstore 522 KB 522 KB 0 B 0% 🟢
bot-web-ui 773 KB 773 KB +12 B +0.0% 🟢
cashier 696 KB 696 KB 0 B 0% 🟢
cashier-v2 3.2 MB 3.2 MB 0 B 0% 🟢
cfd 136 KB 136 KB 0 B 0% 🟢
core 6.8 MB 6.8 MB +70 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 59 KB 59 KB 0 B 0% 🟢
trader 416 KB 417 KB +371 B +0.1% 🟢
wallets 3.9 MB 3.9 MB 0 B 0% 🟢

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024

package old new diff pct change
account 191 KB 191 KB 0 B 0% 🟢
appstore 522 KB 522 KB 0 B 0% 🟢
bot-web-ui 773 KB 773 KB +7 B +0.0% 🟢
cashier 696 KB 696 KB 0 B 0% 🟢
cashier-v2 3.2 MB 3.2 MB 0 B 0% 🟢
cfd 136 KB 136 KB 0 B 0% 🟢
core 6.8 MB 6.8 MB +68 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 59 KB 59 KB 0 B 0% 🟢
trader 417 KB 417 KB +371 B +0.1% 🟢
wallets 3.9 MB 3.9 MB 0 B 0% 🟢

@kate-deriv
DTRA-1569 / Kate / Filter resetting issue (#16359)
c2d268a 
* fix: resetting filter issue

* refactor: add date clear on unmount

* refactor: tests

* fix: tests

* fix: console error
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024

package old new diff pct change
account 191 KB 191 KB 0 B 0% 🟢
appstore 522 KB 522 KB 0 B 0% 🟢
bot-web-ui 783 KB 783 KB +8 B +0.0% 🟢
cashier 696 KB 696 KB 0 B 0% 🟢
cashier-v2 3.2 MB 3.2 MB 0 B 0% 🟢
cfd 136 KB 136 KB 0 B 0% 🟢
core 6.8 MB 6.8 MB +71 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 59 KB 59 KB +62 B +0.1% 🟢
trader 418 KB 418 KB +522 B +0.1% 🟢
wallets 3.9 MB 3.9 MB 0 B 0% 🟢

@akmal-deriv
Akmal / fix: wrong duration unit for digit contracts (#16378)
3eea540 
* fix: wrong duration unit for digit contracts

* fix: test case
@akmal-deriv
Akmal / fix: take profit & stop loss decimals (#16195)
f7fbcda 
* fix: remove decimals from take profit

* fix: apply fixes from quill library

* fix: apply dynamic decimal places based on currency

* feat: update quill-ui version
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024

package old new diff pct change
account 191 KB 191 KB 0 B 0% 🟢
appstore 522 KB 522 KB 0 B 0% 🟢
bot-web-ui 783 KB 783 KB +8 B +0.0% 🟢
cashier 696 KB 696 KB 0 B 0% 🟢
cashier-v2 3.2 MB 3.2 MB 0 B 0% 🟢
cfd 136 KB 136 KB 0 B 0% 🟢
core 6.8 MB 6.8 MB +70 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 59 KB 59 KB +62 B +0.1% 🟢
trader 418 KB 418 KB +560 B +0.1% 🟢
wallets 3.9 MB 3.9 MB 0 B 0% 🟢

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024

package old new diff pct change
account 191 KB 191 KB 0 B 0% 🟢
appstore 522 KB 522 KB 0 B 0% 🟢
bot-web-ui 783 KB 783 KB +8 B +0.0% 🟢
cashier 696 KB 696 KB 0 B 0% 🟢
cashier-v2 3.2 MB 3.2 MB 0 B 0% 🟢
cfd 136 KB 136 KB 0 B 0% 🟢
core 6.8 MB 6.8 MB +68 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 59 KB 59 KB +62 B +0.1% 🟢
trader 418 KB 418 KB +568 B +0.1% 🟢
wallets 3.9 MB 3.9 MB 0 B 0% 🟢

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 26, 2024

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024

package old new diff pct change
account 191 KB 191 KB 0 B 0% 🟢
appstore 526 KB 526 KB 0 B 0% 🟢
bot-web-ui 783 KB 783 KB +8 B +0.0% 🟢
cashier 612 KB 612 KB 0 B 0% 🟢
cashier-v2 3.2 MB 3.2 MB 0 B 0% 🟢
cfd 136 KB 136 KB 0 B 0% 🟢
core 6.8 MB 6.8 MB +57 B +0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 59 KB 59 KB +62 B +0.1% 🟢
trader 418 KB 418 KB +564 B +0.1% 🟢
wallets 3.9 MB 3.9 MB +1 B +0.0% 🟢

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024

⏳ Generating Lighthouse report...

@vinu-deriv vinu-deriv merged commit bc9bcb5 into master Aug 27, 2024
@vinu-deriv vinu-deriv deleted the position-and-contract-details-fixes branch August 27, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akmal-deriv akmal-deriv akmal-deriv approved these changes

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

+1 more reviewer

@kate-deriv kate-deriv kate-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Shared Trader

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@balakrishna-deriv @coveralls @akmal-deriv @kate-deriv @vinu-deriv @ahmadtaimoor-deriv