Skip to content

Conversation

@rupato-deriv
Copy link
Contributor

Over written the variable blocks because after the update the custom variable blocks were not updating the id if the names were same so had to overwite the blockly method.

@vercel
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 2, 2024 5:56am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16272](https://github.com/binary-com/deriv-app/pull/16272)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-variable-blocks.binary.sx?qa_server=red.derivws.com&app_id=24160
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-variable-blocks.binary.sx
- **App ID**: `24160`

@rupato-deriv rupato-deriv changed the title fix: for custom variable strategy [Rupato]/fix: for custom variable strategy Jul 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 34
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-fix-variable-blocks.binary.sx/

@coveralls
Copy link

coveralls commented Jul 30, 2024

Coverage Status

coverage: 46.545% (+0.2%) from 46.351%
when pulling 492b057 on rupato-deriv:Rupato/Fix--variable-blocks
into 51d4b18 on binary-com:master.

farabi-deriv
farabi-deriv previously approved these changes Aug 1, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2024

@sandeep-deriv sandeep-deriv merged commit 9b90e18 into deriv-com:master Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants