Skip to content

Conversation

hasan-deriv
Copy link
Contributor

@hasan-deriv hasan-deriv commented Aug 2, 2024

Changes:

  • removd prop-types
  • moved component to it's own directory
  • fixed types and testing errors

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 5, 2024 4:10am

Copy link
Contributor

github-actions bot commented Aug 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16346](https://github.com/binary-com/deriv-app/pull/16346)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hasan-deriv-hasan-cfds-4333refactor-i-a8ffbf.binary.sx?qa_server=red.derivws.com&app_id=23836
    - **Original**: https://deriv-app-git-fork-hasan-deriv-hasan-cfds-4333refactor-i-a8ffbf.binary.sx
- **App ID**: `23836`

Copy link
Contributor

github-actions bot commented Aug 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 34
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-hasan-deriv-hasan-cfds-4333refactor-i-a8ffbf.binary.sx/

@coveralls
Copy link

coveralls commented Aug 2, 2024

Coverage Status

coverage: 46.54% (-0.009%) from 46.549%
when pulling c1f890e on hasan-deriv:hasan/CFDS-4333/refactor-investor-password-manager
into f1ee508 on binary-com:master.

Copy link

sonarqubecloud bot commented Aug 5, 2024

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Generating Lighthouse report...

@hasan-deriv hasan-deriv marked this pull request as ready for review August 5, 2024 05:06
@hasan-deriv hasan-deriv changed the title fix: moved investor password manager and it's test to it's own directory [CFDS]/Hasan/CFDS-4333/Refactor Investor password manager Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants