-
Notifications
You must be signed in to change notification settings - Fork 379
Suisin/chore: solve validation message issue #8691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suisin/chore: solve validation message issue #8691
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-94934validationme-676088.binary.sx/ |
.../src/Components/poi/poi-form-on-signup/idv-doc-submit-on-signup/idv-doc-submit-on-signup.tsx
Outdated
Show resolved
Hide resolved
.../src/Components/poi/poi-form-on-signup/idv-doc-submit-on-signup/idv-doc-submit-on-signup.tsx
Outdated
Show resolved
Hide resolved
.../src/Components/poi/poi-form-on-signup/idv-doc-submit-on-signup/idv-doc-submit-on-signup.tsx
Outdated
Show resolved
Hide resolved
60b95dc
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | 8fb9e6d | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
- | Generic High Entropy Secret | 8fb9e6d | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Codecov Report
@@ Coverage Diff @@
## master #8691 +/- ##
==========================================
+ Coverage 19.98% 20.01% +0.02%
==========================================
Files 1817 1816 -1
Lines 41156 41153 -3
Branches 8178 8176 -2
==========================================
+ Hits 8227 8236 +9
+ Misses 32085 32074 -11
+ Partials 844 843 -1
|
c3a4380
to
da914a0
Compare
Kudos, SonarCloud Quality Gate passed!
|
⏳ Generating Lighthouse report... |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed. |
Reopened the PR |
…94934/validation_message_is_not_proper
…b.com:suisin-deriv/deriv-app into suisin/94934/validation_message_is_not_proper
…94934/validation_message_is_not_proper
Kudos, SonarCloud Quality Gate passed!
|
Changes:
Change validation message to include document's name
Screenshots:
Please provide some screenshots of the change.