Skip to content

Conversation

suisin-deriv
Copy link
Contributor

Changes:

Change validation message to include document's name

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 6:36am

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8691](https://github.com/binary-com/deriv-app/pull/8691)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-94934validationme-676088.binary.sx?qa_server=red.binaryws.com&app_id=32210
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-94934validationme-676088.binary.sx
- **App ID**: `32210`

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-94934validationme-676088.binary.sx/

shaheer-deriv
shaheer-deriv previously approved these changes May 22, 2023
aizad-deriv
aizad-deriv previously approved these changes May 22, 2023
@gitguardian
Copy link

gitguardian bot commented Jun 2, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 8fb9e6d packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
- Generic High Entropy Secret 8fb9e6d packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #8691 (5d49bd6) into master (ed0eca0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8691      +/-   ##
==========================================
+ Coverage   19.98%   20.01%   +0.02%     
==========================================
  Files        1817     1816       -1     
  Lines       41156    41153       -3     
  Branches     8178     8176       -2     
==========================================
+ Hits         8227     8236       +9     
+ Misses      32085    32074      -11     
+ Partials      844      843       -1     
Impacted Files Coverage Δ
...ts/poi/idv-document-submit/idv-document-submit.tsx 60.93% <ø> (-3.93%) ⬇️
packages/account/src/Helpers/utils.tsx 79.54% <100.00%> (ø)

... and 1 file with indirect coverage changes

@suisin-deriv suisin-deriv force-pushed the suisin/94934/validation_message_is_not_proper branch from c3a4380 to da914a0 Compare June 6, 2023 03:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.7% 3.7% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Generating Lighthouse report...

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 8, 2023
@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

@github-actions github-actions bot closed this Aug 14, 2023
@amina-deriv amina-deriv removed the Stale label Sep 14, 2023
@amina-deriv
Copy link
Contributor

Reopened the PR

…b.com:suisin-deriv/deriv-app into suisin/94934/validation_message_is_not_proper
amina-deriv
amina-deriv previously approved these changes Sep 14, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants