Skip to content

thisyahlen/chore: add test coverage for get-more-wallet-card #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

thisyahlen/chore: add test coverage for get-more-wallet-card #8693

wants to merge 5 commits into from

Conversation

@thisyahlen-deriv
Copy link
Contributor

@thisyahlen-deriv thisyahlen-deriv commented May 22, 2023

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented May 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 2:50am

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.6% 5.6% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/8693](https://github.com/binary-com/deriv-app/pull/8693)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-testcover-bdc4ec.binary.sx?qa_server=red.binaryws.com&app_id=32942
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-testcover-bdc4ec.binary.sx
- **App ID**: `32942`

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-testcover-bdc4ec.binary.sx/

@gitguardian
Copy link

gitguardian bot commented Jun 23, 2023 •
edited
Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 173a6df packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
- Generic High Entropy Secret 173a6df packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #8693 (173a6df) into master (d5c38a0) will not change coverage.
Report is 175 commits behind head on master.
The diff coverage is n/a.

❗ Current head 173a6df differs from pull request most recent head a101983. Consider uploading reports for the commit a101983 to get more accurate results

@@          Coverage Diff           @@
##           master   #8693   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3425    3425           
  Branches      893     893           
======================================
  Hits            2       2           
  Misses       3423    3423

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023 •
edited
Loading

⏳ Generating Lighthouse report...

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented Jul 25, 2023 •
edited
Loading

Coverage Status

Changes unknown when pulling a101983 on thisyahlen-deriv:thisyahlen/test_coverage_for_get_more_wallet_card into ** on binary-com:master**.

@sandeep-deriv sandeep-deriv reopened this Aug 9, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shayan-deriv shayan-deriv shayan-deriv approved these changes

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@mahdiyeh-deriv mahdiyeh-deriv Awaiting requested review from mahdiyeh-deriv

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

+3 more reviewers

@farzin-deriv farzin-deriv farzin-deriv approved these changes

@hamid-deriv hamid-deriv hamid-deriv approved these changes

@aum-deriv aum-deriv aum-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AppStore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@thisyahlen-deriv @coveralls @farzin-deriv @shayan-deriv @hamid-deriv @aum-deriv @sandeep-deriv