Skip to content

FarhanNurzi/WALL-1104/real-account-transfer-between-accounts-derivez #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
farhan-nurzi-deriv wants to merge 10 commits into from
Closed

FarhanNurzi/WALL-1104/real-account-transfer-between-accounts-derivez #9265

farhan-nurzi-deriv wants to merge 10 commits into from

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Jul 6, 2023 •
edited
Loading

Changes:

Please provide a summary of the change.

Screenshots:

Screenshot 2023-07-05 at 3 20 04 PM

Screenshot 2023-07-05 at 3 20 31 PM

@vercel
Copy link

vercel bot commented Jul 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 2:48am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 18
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-wall-1104-real-acc-f0ac78.binary.sx/

@farhan-nurzi-deriv farhan-nurzi-deriv changed the title FarhanNurzi/WALL-1104/Deriv EZ real account transfer between accounts FarhanNurzi/WALL-1104/DerivEZ-real-account-transfer-between-accounts Jul 6, 2023
@farhan-nurzi-deriv farhan-nurzi-deriv changed the title FarhanNurzi/WALL-1104/DerivEZ-real-account-transfer-between-accounts FarhanNurzi/WALL-1104/real-account-transfer-between-accounts-derivez Jul 6, 2023
@farhan-nurzi-deriv farhan-nurzi-deriv force-pushed the WALL-1104/real-account-transfer-between-accounts-derivez branch from 50b6a0c to db4e599 Compare July 6, 2023 06:35
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9265](https://github.com/binary-com/deriv-app/pull/9265)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-wall-1104-real-acc-f0ac78.binary.sx?qa_server=red.binaryws.com&app_id=24219
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-wall-1104-real-acc-f0ac78.binary.sx
- **App ID**: `24219`

@coveralls
Copy link

coveralls commented Jul 6, 2023 •
edited
Loading

Coverage Status

coverage: 8.928% (+0.006%) from 8.922% when pulling 242d7a8 on farhan-nurzi-deriv:WALL-1104/real-account-transfer-between-accounts-derivez into e8b8656 on binary-com:master.

shontzu-deriv
shontzu-deriv suggested changes Jul 6, 2023
View reviewed changes
ameerul-deriv
ameerul-deriv approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hamza-deriv
hamza-deriv approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@hamza-deriv hamza-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

⏳ Generating Lighthouse report...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

@github-actions github-actions bot closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farrah-deriv farrah-deriv farrah-deriv left review comments

+4 more reviewers

@niloofar-deriv niloofar-deriv niloofar-deriv left review comments

@shontzu-deriv shontzu-deriv shontzu-deriv requested changes

@ameerul-deriv ameerul-deriv ameerul-deriv approved these changes

@hamza-deriv hamza-deriv hamza-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@farhan-nurzi-deriv @coveralls @farrah-deriv @niloofar-deriv @ameerul-deriv @shontzu-deriv @hamza-deriv @Farhan-slurrp