Skip to content

Farabi/prodqa 1168/change sort placement on toolbar #9394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 25, 2023
Merged

Farabi/prodqa 1168/change sort placement on toolbar #9394

merged 6 commits into from
Jul 25, 2023

Conversation

@farabi-deriv
Copy link
Contributor

@farabi-deriv farabi-deriv commented Jul 20, 2023

Changes:

  • Changed sort button position to the 4th place to emphasise the sort functionality
  • Changed the pop over message for sort button from sort to sort blocks for a more precise understanding
  • Added a vertical divider between undo/redo buttons and zoom in/zoom out buttons
  • Added and updated paddings for dashboard tab to align the paddings across the application

@boring-cyborg boring-cyborg bot added the Bot label Jul 20, 2023
@vercel
Copy link

vercel bot commented Jul 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 21, 2023 10:02am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9394](https://github.com/binary-com/deriv-app/pull/9394)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-prodqa-1168change-cf30df.binary.sx?qa_server=red.binaryws.com&app_id=24190
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-prodqa-1168change-cf30df.binary.sx
- **App ID**: `24190`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-prodqa-1168change-cf30df.binary.sx/

@coveralls
Copy link

coveralls commented Jul 21, 2023 •
edited
Loading

Coverage Status

coverage: 8.884%. remained the same when pulling 4f40412 on farabi-deriv:farabi/prodqa-1168/change-sort-placement-on-toolbar into 2702503 on binary-com:master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

⏳ Generating Lighthouse report...

@bahar-sadeghzadeh bahar-sadeghzadeh merged commit a81b55c into deriv-com:master Jul 25, 2023
matin-deriv pushed a commit to matin-deriv/deriv-app that referenced this pull request Aug 2, 2023
@farabi-deriv @matin-deriv
Farabi/prodqa 1168/change sort placement on toolbar (deriv-com#9394)
d61c6fb 
* fix: sort button placement and padding alignment on dashboard

* fix: alignment of tables and texts in dashboard mobile

* fix: add padding on selected strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@sandeep-deriv sandeep-deriv sandeep-deriv approved these changes

@rupato-deriv rupato-deriv rupato-deriv approved these changes

@shafin-deriv shafin-deriv shafin-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@farabi-deriv @coveralls @sandeep-deriv @rupato-deriv @shafin-deriv @bahar-sadeghzadeh