Skip to content

Conversation

sergei-deriv
Copy link
Contributor

@sergei-deriv sergei-deriv commented Jul 31, 2023

Changes:

  • Change wallet loginid to related trading account loginid
  • Add check for trading account and show 'Get' button if there is not linked trading account
  • Create useTradingAccountsList hook

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 8, 2023 2:41pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9510](https://github.com/binary-com/deriv-app/pull/9510)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-1397wrong-ac-8282bd.binary.sx?qa_server=red.binaryws.com&app_id=32508
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-1397wrong-ac-8282bd.binary.sx
- **App ID**: `32508`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-wall-1397wrong-ac-8282bd.binary.sx/

@coveralls
Copy link

coveralls commented Jul 31, 2023

Coverage Status

coverage: 10.177% (+0.008%) from 10.169% when pulling d48d40b on sergei-deriv:sergei/wall-1397/wrong-account-number into 69b284d on binary-com:feature/wallets_with_traders_hub.

@boring-cyborg boring-cyborg bot added the Core label Aug 1, 2023
…ub' into sergei/wall-1397/wrong-account-number
@nijil-deriv nijil-deriv changed the base branch from feature/wallets_with_traders_hub to feature/wallets_with_traders_hub_2 August 8, 2023 09:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nijil-deriv nijil-deriv merged commit 0ff6711 into deriv-com:feature/wallets_with_traders_hub_2 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants