Skip to content

chore:Fix tap twice for manage account #9562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 2, 2023
Merged

chore:Fix tap twice for manage account #9562

merged 17 commits into from
Oct 2, 2023

Conversation

suisin-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Aug 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 25, 2023 4:28am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9562](https://github.com/binary-com/deriv-app/pull/9562)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-wall1376taptwicef-8c9c9f.binary.sx?qa_server=red.binaryws.com&app_id=23851
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-wall1376taptwicef-8c9c9f.binary.sx
- **App ID**: `23851`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-wall1376taptwicef-8c9c9f.binary.sx/

@coveralls
Copy link

coveralls commented Aug 3, 2023 •
edited
Loading

Coverage Status

coverage: 10.68% (-0.001%) from 10.681% when pulling 0e4b5e1 on suisin-deriv:suisin/WALL1376/tap_twice_for_manage_account into 0e24aac on binary-com:master.

shaheer-deriv
shaheer-deriv reviewed Aug 4, 2023
View reviewed changes
packages/components/src/hooks/use-hover.ts Outdated
refSetter?: RefObject<T> | null,
should_prevent_bubbling?: boolean
) => {
const isMobile = /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(navigator.userAgent);
Copy link
Contributor

@shaheer-deriv shaheer-deriv Aug 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to use isMobile from stores/shared/hook?
i saw isMobile already defined somewhere..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't import isMobile from stores since the components package doesn't have any stores hook implemented inside

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use IsMobile from shared package for the time being till components package is exposed to stores

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reuse isMobileOs from the shared package.

thisyahlen-deriv
thisyahlen-deriv reviewed Aug 4, 2023
View reviewed changes
matin-deriv
matin-deriv previously approved these changes Aug 7, 2023
View reviewed changes
amina-deriv
amina-deriv reviewed Aug 7, 2023
View reviewed changes
amina-deriv
amina-deriv previously approved these changes Aug 7, 2023
View reviewed changes
@suisin-deriv suisin-deriv dismissed stale reviews from amina-deriv and matin-deriv via edfce2c August 11, 2023 06:12
amina-deriv
amina-deriv previously approved these changes Aug 15, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.3% 1.3% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

@sandeep-deriv sandeep-deriv merged commit ac78e31 into deriv-com:master Oct 2, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@suisin-deriv @vinu-deriv
chore:Fix tap twice for manage account (#9562)
48dae17 
* chore: test for mobile

* chore: test out touchstart

* chore: test use isMobile

* chore: fix mobile double touch issue

* chore: edit based on comments

* chore: remove unused file

* chore: add isMobileOs from @deriv/shared

* chore: test changes on phone

* chore: add React.useCallback to DefaultMobileLinks

* chore: update to see mobile change

* chore: revert back to previous code

* chore: test in mobile

* chore: check on mobile view
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@suisin-deriv @vinu-deriv
chore:Fix tap twice for manage account (#9562)
06aafea 
* chore: test for mobile

* chore: test out touchstart

* chore: test use isMobile

* chore: fix mobile double touch issue

* chore: edit based on comments

* chore: remove unused file

* chore: add isMobileOs from @deriv/shared

* chore: test changes on phone

* chore: add React.useCallback to DefaultMobileLinks

* chore: update to see mobile change

* chore: revert back to previous code

* chore: test in mobile

* chore: check on mobile view
maryia-deriv added a commit to maryia-deriv/deriv-app that referenced this pull request Oct 27, 2023
@maryia-deriv
revert: chore:Fix tap twice for manage account deriv-com#9562
80a904d
@maryia-deriv maryia-deriv mentioned this pull request Oct 27, 2023
Closed
maryia-deriv added a commit to maryia-deriv/deriv-app that referenced this pull request Oct 29, 2023
@maryia-deriv
revert: chore:Fix tap twice for manage account deriv-com#9562
b914a0e
@maryia-deriv maryia-deriv mentioned this pull request Oct 29, 2023
Merged
maryia-deriv added a commit to maryia-deriv/deriv-app that referenced this pull request Oct 29, 2023
@maryia-deriv
revert: chore:Fix tap twice for manage account deriv-com#9562
ba6b645
maryia-deriv added a commit that referenced this pull request Nov 2, 2023
@maryia-deriv
Maryia/DTRA-453/fix: Tooltips are not working properly in mobile, req…
c501f78 
…uire holding i button (#11027)

* revert: chore:Fix tap twice for manage account #9562

* fix: usehover type

* fix: onboarding redirection

* fix: no need for tooltips in mobile, need to redirect straight

* test: added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

@shahzaib-deriv shahzaib-deriv shahzaib-deriv approved these changes

@matin-deriv matin-deriv matin-deriv left review comments

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

+3 more reviewers

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv left review comments

@shaheer-deriv shaheer-deriv shaheer-deriv left review comments

@ameerul-deriv ameerul-deriv ameerul-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Components Core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@suisin-deriv @coveralls @matin-deriv @amina-deriv @ameerul-deriv @thisyahlen-deriv @shaheer-deriv @shahzaib-deriv @sandeep-deriv