chore: add german language for deriv.app #9737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
requested review from
ali-hosseini-deriv,
farrah-deriv,
matin-deriv and
nijil-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-wall1529addgerman-8592d2.binary.sx/ |
shaheer-deriv
approved these changes
Aug 17, 2023
amina-deriv
reviewed
Aug 17, 2023
…WALL1529/add_german_language
amina-deriv
previously approved these changes
Aug 18, 2023
matin-deriv
requested changes
Aug 21, 2023
Contributor
matin-deriv
left a comment
matin-deriv
left a comment
There was a problem hiding this comment.
Pending from this PR:
- Add this new language to P2P since they have a separate translation procedure.
- Wait for SmartCharts release and include the new version of that repo to this PR
Other than that, LGTM
maryia-deriv
previously approved these changes
Aug 21, 2023
farrah-deriv
previously approved these changes
Aug 22, 2023
…WALL1529/add_german_language
maryia-deriv
approved these changes
Sep 11, 2023
…WALL1529/add_german_language
maryia-deriv
previously approved these changes
Sep 11, 2023
farrah-deriv
previously approved these changes
Sep 11, 2023
amina-deriv
reviewed
Sep 11, 2023
…WALL1529/add_german_language
suisin-deriv
dismissed stale reviews from farrah-deriv and maryia-deriv
via
ebab3bf
maryia-deriv
previously approved these changes
Sep 12, 2023
amina-deriv
previously approved these changes
Sep 12, 2023
matin-deriv
previously approved these changes
Sep 12, 2023
…WALL1529/add_german_language
…WALL1529/add_german_language
suisin-deriv
dismissed stale reviews from maryia-deriv, amina-deriv, and matin-deriv
via
415151c
…WALL1529/add_german_language
|
Kudos, SonarCloud Quality Gate passed!
|
amina-deriv
approved these changes
Sep 22, 2023
matin-deriv
approved these changes
Sep 22, 2023
farrah-deriv
approved these changes
Sep 22, 2023
vinu-deriv
pushed a commit
that referenced
this pull request
Oct 10, 2023
* chore: add german language for deriv.app * chore: empty * chore: remove ? because it is fixed in master * chore: add German Language in p2p/i18 package as well * chore: update charts to latest version * chore: resolve bug from Germany language * chore: update scss to remove padding in text * chore: package-lock.json * chore: resolve text overlapping screen in mobile * chore: update scss to fix title issue * chore: edit scss for text * chore: update charts version * chore: remove text-align center * chore: update charts package * chore: update scss and Text component
vinu-deriv
pushed a commit
that referenced
this pull request
Oct 10, 2023
* chore: add german language for deriv.app * chore: empty * chore: remove ? because it is fixed in master * chore: add German Language in p2p/i18 package as well * chore: update charts to latest version * chore: resolve bug from Germany language * chore: update scss to remove padding in text * chore: package-lock.json * chore: resolve text overlapping screen in mobile * chore: update scss to fix title issue * chore: edit scss for text * chore: update charts version * chore: remove text-align center * chore: update charts package * chore: update scss and Text component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Add German Language to app.deriv
Screenshots:
Please provide some screenshots of the change.