Skip to content

Conversation

@hirad-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 28, 2023 3:29am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9762](https://github.com/binary-com/deriv-app/pull/9762)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hirad-deriv-ts-migration-tests-contai-7d64e9.binary.sx?qa_server=red.binaryws.com&app_id=23840
    - **Original**: https://deriv-app-git-fork-hirad-deriv-ts-migration-tests-contai-7d64e9.binary.sx
- **App ID**: `23840`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hirad-deriv-ts-migration-tests-contai-7d64e9.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 10.135%. remained the same when pulling 9b0f4c9 on hirad-deriv:TS-migration/tests-Containers-init-store-templates-Utils into 6ad6607 on binary-com:master.

shontzu-deriv
shontzu-deriv approved these changes Aug 21, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any difference between this component and packages/components/src/components/loading/loading.tsx? 🤔

@boring-cyborg boring-cyborg bot added the Docs label Aug 28, 2023
…est-files-migration

Hamza/refactor: migrated test files of containers to typescript
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 7 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor Author

@hirad-deriv hirad-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is kept as it is since its type migration is being used in the cfd refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants